Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] The "x" from Send and Share page is barely visible (HTC device specific?) #3547

Closed
lobontiumira opened this issue Jun 19, 2019 · 8 comments
Closed

[Bug] The "x" from Send and Share page is barely visible (HTC device specific?) #3547

lobontiumira opened this issue Jun 19, 2019 · 8 comments
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Milestone
v1.1

Comments

@lobontiumira
Copy link

lobontiumira commented Jun 19, 2019 •
edited by data-sync-user

Steps to reproduce

  1. Open a webpage.
  2. From QAB select Share.
  3. Observe the closing "x" button from the Send and Share page.

Expected behavior

The "x" should be visible.

Actual behavior

The "x" is black and barely visible.

Device information

  • Android device: Google Pixel (Android Q), Lenovo TB3-850M (Android 6), Huawei MediaPad M3 Lite 10 (Android 7.0)
  • Fenix version: 1.0.0-rc.2 (#11700147)

ScreenshotUNITO-UNDERSCORE!20190619-112630!

┆Issue is synchronized with this Jira Task
@lobontiumira lobontiumira added 🐞 bug Crashes, Something isn't working, .. visual design labels Jun 19, 2019
@vesta0 vesta0 added the P1 Current sprint label Jun 19, 2019
@vesta0 vesta0 added this to the Fenix 1.1 Backlog milestone Jun 19, 2019
@vesta0 vesta0 removed P1 Current sprint labels Jun 21, 2019
@sblatz sblatz added the good first issue Good for newcomers label Jun 21, 2019
@sblatz
Copy link
Contributor

sblatz commented Jun 21, 2019

The "x" should match the primary text color of the theme.

@danielnemenyi
Copy link

Could not reproduce this in either Light, Dark or Set by Battery Saver theme modes of Firefox Preview 1.0.0 (Build #11721514). Is it still an issue?

@sblatz sblatz added the eng:qa:needed QA Needed label Jun 28, 2019
@sblatz
Copy link
Contributor

sblatz commented Jun 28, 2019

Marking this as QA needed to see if it's still reproducible.

@Geojackson
Copy link

Greatly appreciate

@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 1, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jul 1, 2019

Hi, verified as fixed on Fenix #11791805 from 28/6 for both light and dark themes using the following devices:
• Google Pixel 3XL (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7.0)
• Samsung Galaxy J7 (Android 6.0.1)
• Sony Xperia Z3 (Android 5.1.1)

@AndiAJ AndiAJ closed this as completed Jul 1, 2019
@lobontiumira
Copy link
Author

It is not fixed on HTC Desire 820 (Android 6.0.1). Tested on 7/2 build.

Screenshot_20190702-172130

@lobontiumira lobontiumira reopened this Jul 2, 2019
@sblatz sblatz removed the eng:qa:verified QA Verified label Jul 2, 2019
@sblatz sblatz changed the title [Bug] The "x" from Send and Share page is barely visible [Bug] The "x" from Send and Share page is barely visible (HTC device specific?) Jul 2, 2019
@sblatz sblatz removed the good first issue Good for newcomers label Jul 2, 2019
@vesta0 vesta0 modified the milestones: Fenix 1.1 Backlog, Bugs Jul 2, 2019
@vesta0 vesta0 added the P1 Current sprint label Jul 2, 2019
@vesta0 vesta0 modified the milestones: Bugs, Fenix 1.1 Backlog Jul 3, 2019
@bifleming bifleming removed the P1 Current sprint label Jul 3, 2019
@ekager ekager self-assigned this Jul 4, 2019
ekager added a commit to ekager/fenix that referenced this issue Jul 4, 2019
@ekager
For mozilla-mobile#3547 - Use MaterialButton for Share Component Clos…
4a9e533 
…e Button
ekager added a commit to ekager/fenix that referenced this issue Jul 8, 2019
@ekager
For mozilla-mobile#3547 - Use MaterialButton for Share Component Clos…
90953fd 
…e Button
ekager added a commit that referenced this issue Jul 8, 2019
@ekager
For #3547 - Use MaterialButton for Share Component Close Button
eaa9df7
@ekager ekager added the eng:qa:needed QA Needed label Jul 8, 2019
@ekager
Copy link
Contributor

ekager commented Jul 8, 2019

I tried a fix that more clearly tints the button, but I don't have an HTC device to test the fix on. Added QA needed label :)

@lobontiumira
Copy link
Author

Verified as fixed on HTC Desire 820 (Android 6.0.1), on the latest build 7/9.

Screenshot_20190709-110908

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 9, 2019
@colintheshots colintheshots modified the milestones: 1.1 Backlog, v1.1 Jul 23, 2019
@data-sync-user data-sync-user changed the title [Bug] The "x" from Send and Share page is barely visible (HTC device specific?) FNX3-17096 ⁃ [Bug] The "x" from Send and Share page is barely visible (HTC device specific?) Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-17096 ⁃ [Bug] The "x" from Send and Share page is barely visible (HTC device specific?) [Bug] The "x" from Send and Share page is barely visible (HTC device specific?) May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests