Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]The 'X' button from Open Tabs section is not entirely visible #3548

Closed
sv-sdeiac opened this issue Jun 19, 2019 · 4 comments
Closed

[Bug]The 'X' button from Open Tabs section is not entirely visible #3548

sv-sdeiac opened this issue Jun 19, 2019 · 4 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified good first issue Good for newcomers

Comments

@sv-sdeiac
Copy link

sv-sdeiac commented Jun 19, 2019 •
edited by data-sync-user

Steps to reproduce

  1. Open Firefox Preview;
  2. Open a page;
  3. Press the tabs button to view the tabs;
  4. Observe the 'Open Tabs' section.

Expected behavior

There are no layout issues.

Actual behavior

The 'X' button to close a tab is bigger and is not entirely visible.

Device information

  • Android device: Xiaomi MiPad 2 (Android 5.1) and Samsung Galaxy Tab A6 (Android 5.1);
  • Fenix version: 1.0.0-rc.2
  • Notes:
    Not reproducible on Lenovo TB3850M (Android 6), Pixel 3XL (android 9), Samsung Galaxy Tab A (Android 7) and Huawei MediaPad M3 Lite 10 (Android 7.0).
    -Screenshot:
    ScreenshotUNITO-UNDERSCORE!27!

┆Issue is synchronized with this Jira Task
@sv-sdeiac sv-sdeiac added the 🐞 bug Crashes, Something isn't working, .. label Jun 19, 2019
@vesta0 vesta0 added needs:UX-feedback Needs UX Feedback P2 Upcoming release labels Jun 19, 2019
@vesta0 vesta0 added this to the Fenix 1.1 Backlog milestone Jun 19, 2019
@vesta0 vesta0 removed P2 Upcoming release labels Jun 21, 2019
@sblatz sblatz added the good first issue Good for newcomers label Jun 21, 2019
bloslo added a commit to bloslo/fenix that referenced this issue Jun 29, 2019
@bloslo
For mozilla-mobile#3548 - Fix close tab button visibility.
e7bbe5f
bloslo added a commit to bloslo/fenix that referenced this issue Jul 2, 2019
@bloslo
For mozilla-mobile#3548 - Fix close tab button visibility.
08ec93f
@vesta0 vesta0 modified the milestones: Fenix 1.1 Backlog, Bugs Jul 3, 2019
@mauryat
Copy link
Contributor

mauryat commented Jul 11, 2019

@sblatz , can I work on this?

@sblatz
Copy link
Contributor

sblatz commented Jul 11, 2019

@mauryat looks like we have a PR open for this already. I'd recommend looking at another issue :)

@topotropic topotropic removed the needs:UX-feedback Needs UX Feedback label Jul 23, 2019
@vesta0 vesta0 removed this from the Bugs and Polish milestone Jul 24, 2019
@sblatz
Copy link
Contributor

sblatz commented Jul 30, 2019

Updated:

image

@sblatz sblatz added the eng:qa:needed QA Needed label Jul 30, 2019
sblatz pushed a commit that referenced this issue Jul 30, 2019
@bloslo @sblatz
For #3548 - Fix close tab button visibility. (#3801)
7ab4498 
* For #3548 - Fix close tab button visibility.

* Switch to 'wrap_content' instead of fixed values.

* Align close tab button with settings button.

* Change margin top
@sv-ohorvath
Copy link
Contributor

Verified as fixed on nightly 190731, devices: Samsung Galaxy Tab A 6 (Android 5.1.1), Sony Xperia Z2 (Android 6.0.1), Xiaomi MiPad 2 (Android 5.1).

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 31, 2019
@data-sync-user data-sync-user changed the title [Bug]The 'X' button from Open Tabs section is not entirely visible FNX3-17097 ⁃ [Bug]The 'X' button from Open Tabs section is not entirely visible Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-17097 ⁃ [Bug]The 'X' button from Open Tabs section is not entirely visible [Bug]The 'X' button from Open Tabs section is not entirely visible May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@topotropic @NotWoods @sv-ohorvath @sblatz @mauryat @sv-sdeiac @vesta0 @data-sync-user