Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Reduce the radius of the rounded corners #3715

Closed
robmv opened this issue Jun 27, 2019 · 8 comments
Closed

[Bug] Reduce the radius of the rounded corners #3715

robmv opened this issue Jun 27, 2019 · 8 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, ..
Milestone

Comments

@robmv
Copy link

robmv commented Jun 27, 2019

Steps to reproduce

Open any menu inside the application, the rounded corners of them are too big. Compare the following Chrome and Firefox Preview screenshots from the same device:

Screenshot_20190627-132112
Screenshot_20190627-132122

Expected behavior

Relatively native looking controls, specially menus rounded corners within Material Design recommendations. There are too many rounded corners, not my personal taste, but the menu ones are too big.

Actual behavior

Menu rounded corners are too big in comparison with other modern Android applications.

Device information

  • Android device: Nexus 5
  • Fenix version: 1.0.0

┆Issue is synchronized with this Jira Task

@robmv robmv added the 🐞 bug Crashes, Something isn't working, .. label Jun 27, 2019
@ekager ekager added the needs:UX-feedback Needs UX Feedback label Jun 27, 2019
@cadeyrn
Copy link
Contributor

cadeyrn commented Jun 27, 2019

I don't think it makes much sense to compare with Chrome because Chrome is Chrome and Fenix is Fenix. It's totally okay to have different designs. FWIW, I am not a big fan of Material design and I like the current border radius of the Fenix menu.

@robmv
Copy link
Author

robmv commented Jun 27, 2019

Thanks for the reply. The comparison with Chrome was to show another application that uses rounded corners on Android, it is not frequent to see those menus yet.

The menu's rounded corner is too large for my taste, compare it with others non menu rounded corners on the same application.

For not being a fan of Material Design, the new UI is taking the most annoying visual aspect of it (the corners) and making it big, like children's toy like interfaces. I hope more feedback comes.

@yoasif
Copy link
Contributor

yoasif commented Jun 27, 2019

I agree that the current menus look a little sloppy, but didn't have a great reason to open a bug about it previously. I think that this makes sense from a platform integration perspective.

@mheubusch
Copy link
Contributor

@AmyYLee please review and close if border radii are as designed.

@mheubusch mheubusch added this to the Bugs milestone Jul 2, 2019
@AmyYLee
Copy link
Collaborator

AmyYLee commented Jul 3, 2019

@sblatz Can you confirm if the boarder radius is 8pt? if it is, please leave it as such as this is the same radius as our tab cards. We should keep the radius consistent throughout the app. Thanks.

@AmyYLee AmyYLee removed the needs:UX-feedback Needs UX Feedback label Jul 3, 2019
@ekager ekager self-assigned this Jul 3, 2019
@ekager
Copy link
Contributor

ekager commented Jul 3, 2019

The radius was not 8dp. Updating now

@ekager
Copy link
Contributor

ekager commented Jul 3, 2019

Updated the menu corner radius, closing this

@ekager ekager closed this as completed Jul 3, 2019
@robmv
Copy link
Author

robmv commented Jul 3, 2019

Thanks everyone involved, with this fixed, adding my next UI related issue

@colintheshots colintheshots modified the milestones: Bugs and Polish, v1.1 Jul 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, ..
Projects
None yet
Development

No branches or pull requests

7 participants