[Bug] Japanese introduction string is incomplete. Shows %s.

[birtles]

Steps to reproduce

1. Open Firefox Preview on a Japanese device

Expected behavior

Something sensible is displayed.

Actual behavior

The string: "Firefox Preview へようこそ！%s を知ろう" is displayed

Device information

• Android device: Pixel 3
• Fenix version: 1.0.0 (Build #11721515 Gecko 68.0-20190611143747)

┆Issue is synchronized with this Jira Task

[kbrosnan]

When we released it was noted that there was one Japanese string that was not translated. Is this the problem that was called out @Delphine ?

[Delphine]

The placeholder '%s ' should be rendering as the app name. No idea why it's not in this case. Will poke around

[birtles]

Let me know if I can help with any additional information.

[flodolo]

CC @marsf

The string was fixed 4 days ago, so it's not in the MVP. The original translation wasn't using %s, just something that looks like it ％s, and breaks the replacement.

Note that we already fixed a bunch of these errors in Japanese when we enabled checks in Transvision (example), but this error was introduced after.

[divya21raj]

On it, will make a PR

[divya21raj]

Fixed, problem was ％ instead of % in the code for some reason.

[flodolo]

On it, will make a PR

I don't think you should, because it's going to mess with automation (@Pike would know for sure).

Note that the string has already been fixed, we only need to export new translations to the repository. Also, that won't affected the current MVP, just next releases.

[Pike]

This is already in #3592, wating to merge.

[marsf]

It was introduced by my fault.
'％' is Japanese full-width character. It shouldn't be used in l10n.

[AndiAJ]

Hi, verified as fixed on the latest Nightly Build #190724 from 24/7 using the following devices:
• Googe Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus 3 (Android 6.0.1)
• Sony Xperia Z3 (Android 5.1.1)