Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Crash loading bookmarks while detached #3784

Closed
colintheshots opened this issue Jun 29, 2019 · 3 comments
Closed

[Bug] Crash loading bookmarks while detached #3784

colintheshots opened this issue Jun 29, 2019 · 3 comments
Assignees
@colintheshots
Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. Feature:Bookmarks
Milestone
v1.1

Comments

@colintheshots
Copy link
Contributor

colintheshots commented Jun 29, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

Unclear steps to reproduce. Open bookmarks fragment and browse quickly to a massive folder and select one immediately.

Expected behavior

Bookmarked page will load.

Actual behavior

BookmarkFragment will crash as the fragment is detached and the coroutine will crash if the activity is null.

Device information

  • Android device: Moto X4
  • Fenix version: 1.0.1926 Nightly

┆Issue is synchronized with this Jira Task
@colintheshots colintheshots added the 🐞 bug Crashes, Something isn't working, .. label Jun 29, 2019
@colintheshots colintheshots self-assigned this Jun 29, 2019
colintheshots added a commit to colintheshots/fenix that referenced this issue Jun 29, 2019
@colintheshots
For mozilla-mobile#3784: Crash loading bookmarks while detached
c250e4f
@kbrosnan kbrosnan added b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info Feature:Bookmarks labels Jul 1, 2019
colintheshots added a commit that referenced this issue Jul 1, 2019
@colintheshots
For #3784: Crash loading bookmarks while detached (#3787)
7473126
@ekager
Copy link
Contributor

ekager commented Jul 16, 2019

@colintheshots do we think this is resolved?

@colintheshots
Copy link
Contributor Author

colintheshots commented Jul 16, 2019 •
edited
Loading

@ekager It hasn't been seen in Nightly since July 1st which corresponds to when it was fixed. It seems resolved.
https://sentry.prod.mozaws.net/operations/fenix-nightly/issues/5991083/?query=is:unresolved%20bookmark

@colintheshots
Copy link
Contributor Author

Closing since there are no steps to reproduce for QA.

@colintheshots colintheshots added this to the v1.1 milestone Jul 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@colintheshots colintheshots

Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. Feature:Bookmarks
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
3 participants
@kbrosnan @colintheshots @ekager