Add linting rule for adding a license

[sblatz]

We should have a linting rule that triggers if a new file does not include the Mozilla license.

┆Issue is synchronized with this Jira Task

[Amejia481]

Similar issue on AC -> mozilla-mobile/android-components#846

[sblatz]

While I'd love to have this, it's not the top of our priorities. Would love a contributor PR on this!

[dector]

Is header format defined in mozilla-mobile/android-components#4460 works in this project as well?

[NotWoods]

Yes, the same header format works here too 😄

[dector]

@NotWoods Cool. I'll make PR today.

[dector]

Should we publish tooling-detekt from AC or just copy-past license plugin? 😄

[pocmo]

@dector Yes, can you try publishing and consuming it from mavenLocal()?

[dector]

@pocmo Sorry for the late reply. I was busy a bit. :(

If I got your proposal right - the idea is to publish module from AC project to local maven repository and reuse it in Fenix project? Isn't it adding explicit dependency on AC?

[pocmo]

@dector Oh, I meant only for testing if everything works. After that we'd actually publish it from AC to maven.mozilla.org

[dector]

@pocmo Ah, sure! Using rulesets from a maven repository works similarly to using rulesets from a separate module.

Should I just set publish: true in .buildconfig.yml or there are is another (preferable) way to publish this ruleset for internal use?

[pocmo]

@pocmo Ah, sure! Using rulesets from a maven repository works similarly to using rulesets from a separate module.

Yeah, it should. But I am not sure whether our build/publish mechanism will work as expected. That's why I would love to try that with a local repository before enabling it in buildconfig.yml. If that works then yes, let's set it to publish: true and then test again with the snapshots. :)

[dector]

@pocmo Awesome! I tested ./gradlew :tooling-detekt:publishToMavenLocal with maven-publish plugin.

I guess main publishing mechanism is implemented in automation/taskcluster/decision_task.py. If it's needed I can try to dig into it and try to publish components to local maven repository first. But I don't expect any troubles with it as other components are published to mozilla maven without any issue.

[eliserichards]

Closing in favor of mozilla-mobile/android-components#6351