Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Home button is not visible #391

Closed
colintheshots opened this issue Feb 6, 2019 · 1 comment
Closed

Home button is not visible #391

colintheshots opened this issue Feb 6, 2019 · 1 comment
Assignees
@colintheshots
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Milestone
Sprint 2-1 (Miles...

Comments

@colintheshots
Copy link
Contributor

colintheshots commented Feb 6, 2019 •
edited by data-sync-user

Steps to reproduce

  1. Open a web page from the search toolbar in-app (as opposed to custom tabs or external intents).

Expected behavior

The home button should appear as it isn't a custom tab.

Actual behavior

The home button does not appear, since the ToolbarIntegration is not aware of the session ID to check if it is a custom tab.

Device information

  • Android device: Android emulator, API 28 x86
  • Fenix version: Milestone 1

┆Issue is synchronized with this Jira Task
@colintheshots colintheshots self-assigned this Feb 6, 2019
@colintheshots colintheshots added 🐞 bug Crashes, Something isn't working, .. P1 Current sprint in progress labels Feb 6, 2019
@colintheshots colintheshots added this to the Sprint 3 (M2) milestone Feb 6, 2019
colintheshots added a commit to colintheshots/fenix that referenced this issue Feb 6, 2019
@colintheshots
Fixes mozilla-mobile#391: Home button is not visible
3b025f8
@ghost ghost added review and removed P1 Current sprint labels Feb 6, 2019
@boek boek closed this as completed in 623dc55 Feb 6, 2019
@ghost ghost removed in progress labels Feb 6, 2019
pocmo added a commit to pocmo/fenix that referenced this issue Feb 8, 2019
@pocmo
Issue mozilla-mobile#391: ToolbarUIView: Do not bind toolbar integrat…
9caa1ea 
…ion to initially selected session.

Instead either use static session id (e.g. in a custom tab) or dynamically follow selected session.
pocmo added a commit to pocmo/fenix that referenced this issue Feb 8, 2019
@pocmo
Issue mozilla-mobile#391: ToolbarUIView: Do not bind toolbar integrat…
fafe83b 
…ion to initially selected session.

Instead either use static session id (e.g. in a custom tab) or dynamically follow selected session.
pocmo added a commit to pocmo/fenix that referenced this issue Feb 8, 2019
@pocmo
Issue mozilla-mobile#391: ToolbarUIView: Do not bind toolbar integrat…
f3d2b89 
…ion to initially selected session.

Instead either use static session id (e.g. in a custom tab) or dynamically follow selected session.
@sv-ohorvath sv-ohorvath added the eng:qa:verified QA Verified label Feb 11, 2019
@sv-ohorvath
Copy link
Contributor

Verified as fixed on 2/10 build.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@colintheshots colintheshots

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Milestone
Sprint 2-1 (Milestone 2)
Development

No branches or pull requests
2 participants
@colintheshots @sv-ohorvath