Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Browser.EXTRA_APPLICATION_ID/EXTRA_CREATE_NEW_TAB support #4106

Closed
buttercookie42 opened this issue Jul 17, 2019 · 3 comments
Closed

Browser.EXTRA_APPLICATION_ID/EXTRA_CREATE_NEW_TAB support #4106

buttercookie42 opened this issue Jul 17, 2019 · 3 comments
Labels
feature request 🌟 New functionality and improvements

Comments

@buttercookie42
Copy link

buttercookie42 commented Jul 17, 2019

Apps wanting to open an URL in the browser can pass along a Browser.EXTRA_APPLICATION_ID Intent extra, meaning they'd like to re-use an already existing tab with the same ID if it already exists instead of opening a new tab.

They can also override that behaviour by also passing along Browser.EXTRA_CREATE_NEW_TAB, which means they'd like to use a fresh tab regardless of whether another tab matching the EXTRA_APPLICATION_ID supplied already exists or not.

┆Issue is synchronized with this Jira Task

@buttercookie42
Copy link
Author

One additional thing not to forget from the Fennec implementation:
Whenever the user opens some other URL in a tab through the browser UI, we clear any possibly stored EXTRA_APPLICATION_ID for that tab, so it can no longer be re-used (thereby overwriting the user's new URL) if another Intent containing an EXTRA_APPLICATION_ID arrives.
What's debatable (and I don't think Fennec does this right now) is whether the same thing might be worth doing if the user navigates by doing something inside the GeckoView, i.e. clicking a link or whatever we can detect as a user-triggered navigation.

@ekager ekager added the feature request 🌟 New functionality and improvements label Dec 10, 2019
@buttercookie42
Copy link
Author

@csadilek
Copy link
Contributor

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1809994

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request 🌟 New functionality and improvements
Projects
None yet
Development

No branches or pull requests

3 participants