Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Quick actions when long-pressing on the nav bar #4155

Closed
vesta0 opened this issue Jul 18, 2019 · 27 comments
Closed

Quick actions when long-pressing on the nav bar #4155

vesta0 opened this issue Jul 18, 2019 · 27 comments
Assignees
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search needs:sumo Mozilla Suport - suport.mozilla.org
Milestone

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Jul 18, 2019

Why/User Benefit/User Problem

As a user, I want a quick and easy way to copy or paste into the nav bar, so I can perform my tasks quicker.

What/Requirements

In Fennec, long pressing on the nav bar brings up a context menu with following options (Paste & Go, Paste, Copy address, Add page shortcut). UX will investigate and design how to bring this feature to Fenix.

Acceptance Criteria (how do I know when I’m done?)

-I can quickly choose to copy the URL by long pressing on the URL bar
-I can quickly choose to paste a URL into the nav bar
-Long pressing on the URL bar will not automatically copy the URL or paste anything into the nav bar.

Note

This is an experiment we'd like to run, but UX work should be timeboxed to ____, and then make a decision whether to continue.


UX spec

  • Long press on URL bar shows context menu with "Copy", "Paste & Go" and "Paste" as entries.
  • When nothing is in the clipboard we still show the "Copy" menu item and people have to select it.
  • When people select "Paste", clipboard is pasted in and search view with keyboard appears.

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added should Feature:Toolbar Address bar, see also Feature:Search labels Jul 18, 2019
@vesta0 vesta0 added this to the Feature Backlog milestone Jul 18, 2019
@vesta0 vesta0 added this to Should in Fenix Q3 Feature Backlog Jul 19, 2019
@vesta0 vesta0 changed the title Quick actions for the nav bar Quick actions when long-pressing on the nav bar Jul 25, 2019
@vesta0 vesta0 modified the milestone: Feature Backlog Jul 26, 2019
@vesta0 vesta0 added this to To be Triaged in Fenix Sprint Kanban via automation Jul 31, 2019
@vesta0 vesta0 moved this from To be Triaged to Prioritized UX Backlog in Fenix Sprint Kanban Jul 31, 2019
@liuche
Copy link
Contributor

liuche commented Jul 31, 2019

Talked about this issue - it's a Should, so if it's not too much work it'll be a nice benefit and UX should pick it up and timebox, but should be skipped if we're behind on UX work.

@vesta0 vesta0 added must and removed should labels Aug 1, 2019
@apbitner apbitner added the ux:s label Aug 6, 2019
@Djfe
Copy link

Djfe commented Aug 7, 2019

some feedback of mine, that you can take into consideration:
I want "tap+hold -> copy to clipboard" back, atleast as an option, it was amazing! <3
it's way faster (one click instead of two)

I get that this can override users' clipboards, so it's good you're searching for an alternative.

my keyboard swiftkey has a clipboard history. therefore I can't accidentally loose my clipboard's content.

paste and paste & go can be placed in the menu that appears if you click the addressbar once. (only paste & go currently and it's named only paste, I think; atleast in german)

if you ever add an option "add to home screen", then it doesn't need to be on tap&hold imo. there are more intuitive places for it.
one example: the menu that appears when you click the lock/globe icon in the addressbar

@topotropic
Copy link

I'd suggest to show a standard context menu with: Cut, Copy, Paste and Share

We wouldn't support "Paste & Go" and "Add page shortcut" in this iteration. @vesta0 thoughts?

@topotropic topotropic moved this from Prioritized UX Backlog to In Design in Fenix Sprint Kanban Aug 9, 2019
@vesta0
Copy link
Collaborator Author

vesta0 commented Aug 9, 2019

@topotropic I am good with your suggestion but is there a reason why we don't want to support "Paste & Go" ?

@colintheshots
Copy link
Contributor

@topotropic What would Cut do here? We're on the browser screen at this point. Would it first open the search page and then cut the entire URL to the copy buffer? It doesn't seem to make sense to Cut unless the user is on a screen where the URL is editable.

Likewise, Paste would seem to require changing to the search screen if it doesn't mean Paste & Go.

@flaki
Copy link

flaki commented Aug 13, 2019

My feedback will echo that of @Djfe — the moment I installed Preview and realized it did the automatic copy on longpress I was startled a bit (I was used to a context menu popping up) but I almost instantly fell in love with the simplicity and usefullness of it. During my day-to-day workflow I want copy URLs way more often than I want to paste-and-go to an URL. I understand this might not match everyone's experience on the planet, but if I could choose I'd keep this in the settings as an option ( "Enable quick URL copy" or something along those lines).

As for exposing "Paste & Go" I'd think exposing it as a contextual option after tapping into the URL bar would be a similarly workable solution (some other browsers show a "go to [url] on clipboard" option underneath the URL editor bar, on top of the suggestions).

@topotropic
Copy link

@colintheshots yeah, that makes sense, I kind of saw it as shortcut to the context menu that appears on the search screen. I'll look into it.

@vesta0 can you point me to the feedback we got about long press to copy? thanks!

@topotropic
Copy link

@vesta0 I'd suggest to have "Copy" and "Paste & Go" assuming that people go to search view when they just want to paste, cut or edit an URL

@vesta0
Copy link
Collaborator Author

vesta0 commented Aug 14, 2019

@topotropic I like your suggestion but I think we may also want to include just "Paste" to give users the option of modifying a URL or search term. What do you think?

Also here's the relevant UR feedback and the UX decision regarding removing the auto-copy feature.

@bifleming bifleming added this to Prioritized Backlog in Fennec to Fenix Transition Aug 14, 2019
@topotropic
Copy link

I don't have a strong opinion here, my main concern about "Paste" is that we go to the search screen and the search box jumps to top and keyboard pops out.

But let's add it, people might wonder how to get to "Paste" when "Paste & go" is in the menu. I'll update the root issue above with the spec.

sblatz added a commit that referenced this issue Sep 11, 2019
@sblatz sblatz added the eng:qa:needed QA Needed label Sep 11, 2019
@sblatz sblatz moved this from In Review to Ready for QA in Fenix Sprint Kanban Sep 11, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Sep 12, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Sep 12, 2019
@sv-ohorvath
Copy link
Contributor

Verified as fixed on build 2.0.0-rc2.

Fenix Sprint Kanban automation moved this from Ready for QA to Done Sep 13, 2019
Fenix Q3 Feature Backlog automation moved this from Should to Done! Sep 13, 2019
@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 13, 2019
@project-bot project-bot bot moved this from Done to In Progress in Fenix Sprint Kanban Sep 13, 2019
@sblatz sblatz moved this from In Progress to Done in Fenix Sprint Kanban Sep 13, 2019
@nahuhh
Copy link

nahuhh commented Sep 14, 2019

Paste and paste & go seem to be unavailable unless the clipboard contains a Valid URL

Paste options should be available as long as the clipboard has is not empty.
If it is not a valid url, it should perform a search.

@sblatz
Copy link
Contributor

sblatz commented Sep 16, 2019

@topotropic Can you verify if the behavior described in @nahuhh's comment is UX's expectation?

Currently "paste" and "paste & go" only display if the clipboard has a URL copied to it. Do you want it to work with search terms as well?

@topotropic
Copy link

Yes, that makes sense. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search needs:sumo Mozilla Suport - suport.mozilla.org
Projects
No open projects
Development

No branches or pull requests