Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Browser bottom toolbar does not auto-hide if ANY accessibility settings are on #427

Closed
colintheshots opened this issue Feb 11, 2019 · 0 comments
Closed

Browser bottom toolbar does not auto-hide if ANY accessibility settings are on #427

colintheshots opened this issue Feb 11, 2019 · 0 comments
Assignees
@colintheshots
Labels
🐞 bug Crashes, Something isn't working, ..

Comments

@colintheshots
Copy link
Contributor

colintheshots commented Feb 11, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Find a device with ANY accessibility settings enabled. Having accessibility services on for a password manager like LastPass is sufficient.
  2. Open any webpage on the Browser fragment.

Expected behavior

The bottom browser toolbar should auto-hide on scroll.

Actual behavior

The bottom browser toolbar does not auto-hide on scroll. This is because we're using the wrong method to check for Talkback and disable auto-hide.

Device information

  • Android device: Pixel 3XL, Android Pie
  • Fenix version: Milestone 1

┆Issue is synchronized with this Jira Task
@colintheshots colintheshots self-assigned this Feb 11, 2019
@colintheshots colintheshots added size S 🐞 bug Crashes, Something isn't working, .. labels Feb 11, 2019
colintheshots added a commit to colintheshots/fenix that referenced this issue Feb 11, 2019
@colintheshots
Fixes mozilla-mobile#427: Browser toolbar does not auto-hide if ANY a…
3d8d6e0 
…ccessibility on
@ghost ghost added in progress labels Feb 11, 2019
@boek boek closed this as completed in 5dcf4e5 Feb 11, 2019
@ghost ghost removed in progress labels Feb 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@colintheshots colintheshots

Labels
🐞 bug Crashes, Something isn't working, ..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colintheshots