Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No text in settings when entered from private browsing #434

Closed
kbrosnan opened this issue Feb 11, 2019 · 2 comments
Closed

No text in settings when entered from private browsing #434

kbrosnan opened this issue Feb 11, 2019 · 2 comments
Assignees
@sblatz
Labels
eng:qa:verified QA Verified
Milestone
Sprint 2-1 (Miles...

Comments

@kbrosnan
Copy link
Contributor

kbrosnan commented Feb 11, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  • Tap on the private browsing icon
  • Tap on the 3 dot menu

Expected behavior

  • text from settings is displayed

Actual behavior

  • no text is displayed
    screenshot-fenix-settings

Device information

  • Android device: Pixel 3 and Galaxy S5
  • Fenix version: ?

┆Issue is synchronized with this Jira Task
@sblatz
Copy link
Contributor

sblatz commented Feb 11, 2019

Good catch. Quick fix--just need to swap out the colors :)

@sblatz sblatz added the size S label Feb 11, 2019
@sblatz sblatz self-assigned this Feb 11, 2019
@sblatz sblatz added this to the Sprint 2-1 (Milestone 2) milestone Feb 11, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 12, 2019
@sblatz
Fixes mozilla-mobile#434: Settings visible in private mode
e4d1f0a
@ghost ghost added in progress labels Feb 12, 2019
@ghost ghost removed in progress labels Feb 12, 2019
@sv-ohorvath sv-ohorvath added the eng:qa:verified QA Verified label Feb 13, 2019
@sv-ohorvath
Copy link
Contributor

Verified as fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sblatz sblatz

Labels
eng:qa:verified QA Verified
Projects
None yet
Milestone
Sprint 2-1 (Milestone 2)
Development

No branches or pull requests
3 participants
@kbrosnan @sv-ohorvath @sblatz