Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Use camelCase for views that are referenced from Kotlin code #4341

Closed
nikit19 opened this issue Jul 27, 2019 · 0 comments
Closed

[Bug] Use camelCase for views that are referenced from Kotlin code #4341

nikit19 opened this issue Jul 27, 2019 · 0 comments
Labels
eng:health Improve code health

Comments

@nikit19
Copy link
Contributor

nikit19 commented Jul 27, 2019 •
edited by data-sync-user

Expected behavior

For views that are referenced from code using synthetic binding should be camel cased

Actual behavior

Views are in snake case currently

I would be converting all views that are referenced from fragments to camel case for now.

┆Issue is synchronized with this Jira Task
@nikit19 nikit19 added the 🐞 bug Crashes, Something isn't working, .. label Jul 27, 2019
@NotWoods NotWoods added eng:health Improve code health and removed 🐞 bug Crashes, Something isn't working, .. labels Jul 28, 2019
ekager pushed a commit that referenced this issue Aug 3, 2019
@nikit19 @ekager
For #4341 use camelCase for views referenced from code
671727c
@ekager ekager closed this as completed Aug 14, 2019
boek pushed a commit that referenced this issue Aug 30, 2019
@Mugurell @boek
For #4007 - Use camelCase for views referenced from code
5e19741 
As per #4341.
Also reformatted layouts to have a more consistent style.
Also refactored `AppShareRecyclerView` and `AccountDevicesShareRecyclerView` by
defining their LayoutManager in XML to reduce code complexity.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:health Improve code health
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NotWoods @nikit19 @ekager