Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Decide what color navigation bar should be in private mode #438

Closed
sblatz opened this issue Feb 11, 2019 · 2 comments
Closed

Decide what color navigation bar should be in private mode #438

sblatz opened this issue Feb 11, 2019 · 2 comments
Assignees

Comments

@sblatz
Copy link
Contributor

sblatz commented Feb 11, 2019

We are currently using a the top gradient color for the background of the toolbar. Because of this, our navigation bar must be the same color for it to blend with the toolbar in the browser view. Unfortunately this means it does not blend nicely on the home view.

Previously

Currently

The original mocks had a white navigation bar, but that seemed to clash with the rest of the darker color scheme.

@brampitoyo any thoughts on this? 😄

┆Issue is synchronized with this Jira Task

@brampitoyo
Copy link

@sblatz Apologies for not specifying the navigation bar colour, and thanks for not forgetting this little but important design detail!

For guidance, let’s look at how things are done in normal browsing.

The current normal home screen shows a navigation bar that’s of a different colour than the background gradient.

This grey-10 navigation bar blends with the grey-10 toolbar when you’re browsing.

Let’s apply the same principle to private browsing.

When browsing privately, we should (as you wrote) “[use] the top gradient color for the background of the toolbar”.

Of course, as a result, “[the navigation bar] does not blend nicely on the home view”. But it will blend when you’re browsing sites, as shown in your example:

In summary, the colour choice you’ve made was the right one!

@sblatz sblatz closed this as completed Feb 12, 2019
@sblatz sblatz reopened this Feb 12, 2019
@sblatz
Copy link
Contributor Author

sblatz commented Feb 12, 2019

Per a conversation with @brampitoyo, it sounds like we want to do a dark bar in the browser fragment and the blended gradient on the home view.

@sblatz sblatz added the size S label Feb 12, 2019
@sblatz sblatz self-assigned this Feb 12, 2019
@sblatz sblatz added this to the Sprint 2-1 (Milestone 2) milestone Feb 12, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 12, 2019
@ghost ghost added in progress labels Feb 12, 2019
@ghost ghost removed in progress labels Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants