Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Share tabs shares all tabs from private and normal browsing #4771

Closed
LaurentiuApahideanSV opened this issue Aug 16, 2019 · 1 comment
Closed
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Milestone

Comments

@LaurentiuApahideanSV
Copy link

LaurentiuApahideanSV commented Aug 16, 2019

Steps to reproduce

  1. Open a few websites in normal and private browsing;
  2. Tap the Open tabs menu, select "Share tabs" and select an app from the share dialog: e.g. gmail.

Expected behavior

Only the tabs from the selected browsing mode should be shared. For example if the user is in normal browsing the tabs opened in private mode should not be shared.

Actual behavior

All the tabs opened in private and normal browsing are shared.

Device information

  • Android device: Samsung Galaxy S8+ (Android 8.0.0)
  • Fenix version: 1.3.0-rc. 1 Thursday 8/15

┆Issue is synchronized with this Jira Task

@LaurentiuApahideanSV LaurentiuApahideanSV added the 🐞 bug Crashes, Something isn't working, .. label Aug 16, 2019
@NotWoods NotWoods self-assigned this Aug 16, 2019
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 16, 2019
Fixes share tabs to use the new method
boek pushed a commit to NotWoods/fenix that referenced this issue Aug 27, 2019
Fixes share tabs to use the new method
boek pushed a commit to NotWoods/fenix that referenced this issue Aug 27, 2019
Fixes share tabs to use the new method
@boek boek closed this as completed in d1964d6 Aug 27, 2019
@boek boek added the eng:qa:needed QA Needed label Aug 27, 2019
@boek boek added this to the v1.4 milestone Aug 27, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 28, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Aug 28, 2019

Hi, verified as fixed on latest Nightly Build #12400613 28/8 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Sharing from NB
20190828_141546

► Sharing from PB
20190828_141626

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Development

No branches or pull requests

4 participants