-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Redesign About page in Settings #4776
Comments
@vesta0 this should be pretty small. it would be nice to get in if we have a bit of time. |
@AmyYLee Is this ready for eng? |
@lime124 please review Amy's design and let us know if this is ENG ready so we can size it during backlog grooming on Wednesday. |
@AmyYLee for a few technical reasons, we need to call out gv libraries separately. Can you add a third row a the bottom under "Open source..." for this. Same layout and styling. Text suggestion: "GeckoView libraries we use" let me ping michelle to see who jeff's back up is. once Amy updates and we have final string we can label ready for eng. thanks! Update see Michelle's comment below for order and string. |
@mheubusch can confirm the copy suggested in my prior comment. thanks! |
I recommend this order/text: |
@lime124 @mheubusch I've updated the mock with the updated copy. This is ready for eng. |
@AmyYLee I think the section "GeckoView libraries we use" should be renamed to "Mozilla libraries we use", as we use two major libraries from Mozilla Geckoview and Android Components |
Hey @AmyYLee sorry to add more requirements after you have already completed working on this ticket but I think it will be easier to do this in one go. Would you please take a look at the Fennec About page below and make sure you have considered all these options? I don't think we need to include all of them but want to make sure that you have considered them all. FYI @lime124 |
@lime124 @vesta0 I reviewed what was in Fennec and either found a Preview equivalent or the same link if it applies to Preview as well and also open questions either one of you. Please see below: FAQ - Do we have a page for Preview? I found Fennec but couldn't find one for Preview (Do we need one?) - I think if we have one it doesn't hurt to add it but if we don't we can leave this out. Support - https://support.mozilla.org/en-US/products/firefox-preview (We should have this) Privacy Policy - https://www.mozilla.org/en-US/privacy/firefox/ (We should have this) Know your rights - about:rights (We should have this) What’s new in Firefox Preview - https://support.mozilla.org/en-US/kb/whats-new-firefox-preview (We should have this) Release Notes - I couldn't find Preview release notes, who should I reach out to find that? (We should have this) Credits - Do we have a list? Do we need it? - I don't think we need this if we don't already have a list. Licensing Information - about:license (We should have this) |
@ValentinTimisica This would be great if it doesn't require a lot of additional effort. Thank you. |
Added new items to be displayed. Due to complexity increase I decided to refactor the component to LibState.
After removing the 'Privacy notice' and 'Help' items from the Settings screen the UI tests for them became unneeded.
FWIW, we do have a credits page: https://www.mozilla.org/credits/ |
Added new items to be displayed.
After removing the 'Privacy notice' and 'Help' items from the Settings screen the UI tests for them became unneeded.
Added new items to be displayed.
After removing the 'Privacy notice' and 'Help' items from the Settings screen the UI tests for them became unneeded.
Added new items to be displayed.
After removing the 'Privacy notice' and 'Help' items from the Settings screen the UI tests for them became unneeded.
Added new items to be displayed.
After removing the 'Privacy notice' and 'Help' items from the Settings screen the UI tests for them became unneeded.
Hi all! I've encountered an issue on Google Pixel (Android Q) regarding the "Privacy notice" page. Thanks! |
pulling up Amy's comment from below:
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: