Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Redesign About page in Settings #4776

Closed
lime124 opened this issue Aug 16, 2019 · 30 comments
Closed

Redesign About page in Settings #4776

lime124 opened this issue Aug 16, 2019 · 30 comments
Assignees
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Settings Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Help wanted from a contributor. More complex than good first issue.

Comments

@lime124
Copy link
Collaborator

lime124 commented Aug 16, 2019

pulling up Amy's comment from below:

Here is the updated mock with additional items we would like to include. Please note that this is a long list so please allow for page scrolling when adding additional items. Thanks!

What’s new in Firefox Preview (in current build) - https://support.mozilla.org/en-US/kb/whats-new-firefox-preview

Support - https://support.mozilla.org/en-US/products/firefox-preview

Privacy notice - https://www.mozilla.org/en-US/privacy/firefox/

Know your rights - about:rights

Licensing Information - about:license

GeckoView libraries we use (in current build)

Other open source libraries we use (in current build)

TBD Release Notes - need to confirm if we have these, @Tif will reach out to Joni Chan

Settings - About Firefox Preview@1x

┆Issue is synchronized with this Jira Task

@lime124
Copy link
Collaborator Author

lime124 commented Aug 16, 2019

@vesta0 this should be pretty small. it would be nice to get in if we have a bit of time.

@vesta0 vesta0 added this to To be Triaged in Fenix Sprint Kanban via automation Aug 22, 2019
@vesta0 vesta0 moved this from To be Triaged to Prioritized UX Backlog in Fenix Sprint Kanban Aug 22, 2019
@lime124 lime124 added the ux:xs label Aug 27, 2019
@vesta0 vesta0 removed this from Could in Fenix Q3 Feature Backlog Sep 16, 2019
@boek boek added the E3 Estimation Point: average, 2 - 3 days label Sep 23, 2019
@AmyYLee AmyYLee assigned AmyYLee and unassigned AmyYLee Oct 7, 2019
@AmyYLee
Copy link
Collaborator

AmyYLee commented Oct 7, 2019

Let me know if there's anything else that needs to be added here:

Settings - About Firefox Preview

@AmyYLee AmyYLee self-assigned this Oct 7, 2019
@NotWoods
Copy link
Contributor

NotWoods commented Oct 7, 2019

@AmyYLee Is this ready for eng?

@vesta0
Copy link
Collaborator

vesta0 commented Oct 8, 2019

@lime124 please review Amy's design and let us know if this is ENG ready so we can size it during backlog grooming on Wednesday.

@lime124
Copy link
Collaborator Author

lime124 commented Oct 10, 2019

@AmyYLee for a few technical reasons, we need to call out gv libraries separately. Can you add a third row a the bottom under "Open source..." for this. Same layout and styling.

Text suggestion: "GeckoView libraries we use"

let me ping michelle to see who jeff's back up is. once Amy updates and we have final string we can label ready for eng. thanks!

Update see Michelle's comment below for order and string.

@lime124
Copy link
Collaborator Author

lime124 commented Oct 10, 2019

@mheubusch can confirm the copy suggested in my prior comment. thanks!

@lime124 lime124 moved this from Prioritized UX Backlog to In Design in Fenix Sprint Kanban Oct 10, 2019
@mheubusch
Copy link
Contributor

I recommend this order/text:
What's new in Firefox Preview
GeckoView libraries we use
Other open source libraries we use

@AmyYLee
Copy link
Collaborator

AmyYLee commented Oct 17, 2019

@lime124 @mheubusch I've updated the mock with the updated copy. This is ready for eng.

Mock

image

@AmyYLee AmyYLee added the eng:ready Ready for engineering label Oct 17, 2019
@AmyYLee AmyYLee moved this from In Design to Prioritized Feature Backlog in Fenix Sprint Kanban Oct 17, 2019
@Amejia481
Copy link
Contributor

@AmyYLee I think the section "GeckoView libraries we use" should be renamed to "Mozilla libraries we use", as we use two major libraries from Mozilla Geckoview and Android Components

@vesta0
Copy link
Collaborator

vesta0 commented Oct 22, 2019

Hey @AmyYLee sorry to add more requirements after you have already completed working on this ticket but I think it will be easier to do this in one go. Would you please take a look at the Fennec About page below and make sure you have considered all these options? I don't think we need to include all of them but want to make sure that you have considered them all.

Screenshot_20191022-153327

FYI @lime124

@vesta0 vesta0 moved this from Prioritized Feature Backlog to Prioritized UX Backlog in Fenix Sprint Kanban Oct 22, 2019
@AmyYLee
Copy link
Collaborator

AmyYLee commented Oct 23, 2019

@lime124 @vesta0 I reviewed what was in Fennec and either found a Preview equivalent or the same link if it applies to Preview as well and also open questions either one of you. Please see below:

FAQ - Do we have a page for Preview? I found Fennec but couldn't find one for Preview (Do we need one?) - I think if we have one it doesn't hurt to add it but if we don't we can leave this out.

Support - https://support.mozilla.org/en-US/products/firefox-preview (We should have this)

Privacy Policy - https://www.mozilla.org/en-US/privacy/firefox/ (We should have this)

Know your rights - about:rights (We should have this)

What’s new in Firefox Preview - https://support.mozilla.org/en-US/kb/whats-new-firefox-preview (We should have this)

Release Notes - I couldn't find Preview release notes, who should I reach out to find that? (We should have this)

Credits - Do we have a list? Do we need it? - I don't think we need this if we don't already have a list.

Licensing Information - about:license (We should have this)

@AmyYLee
Copy link
Collaborator

AmyYLee commented Oct 23, 2019

@lime124 @vesta0 Hi, I also noticed that the screenshot you posted is the "about:firefox" page and not the the "Mozilla Firefox" page that is in-app to Fennec. This is more equivalent I think

Screenshot_20191023-121809

@ValentinTimisica ValentinTimisica added E5 Estimation Point: about 5 days and removed E3 Estimation Point: average, 2 - 3 days labels Nov 26, 2019
@AmyYLee
Copy link
Collaborator

AmyYLee commented Nov 26, 2019

In the current implementation I saw that the item click events are tracked (example for Whats's new item). Should I create a new task for adding telemetry to all the new introduced items?

@ValentinTimisica This would be great if it doesn't require a lot of additional effort. Thank you.

ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Nov 27, 2019
Added new items to be displayed.
Due to complexity increase I decided to refactor the component to LibState.
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Nov 27, 2019
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Nov 27, 2019
After removing the 'Privacy notice' and 'Help' items from the Settings screen
the UI tests for them became unneeded.
@nt1m
Copy link

nt1m commented Nov 29, 2019

FWIW, we do have a credits page: https://www.mozilla.org/credits/

@ValentinTimisica ValentinTimisica moved this from In Progress to In Dev Review in Fenix Sprint Kanban Dec 5, 2019
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Dec 10, 2019
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Dec 10, 2019
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Dec 10, 2019
After removing the 'Privacy notice' and 'Help' items from the Settings screen
the UI tests for them became unneeded.
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Dec 11, 2019
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Dec 11, 2019
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Dec 11, 2019
After removing the 'Privacy notice' and 'Help' items from the Settings screen
the UI tests for them became unneeded.
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Dec 12, 2019
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Dec 12, 2019
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Dec 12, 2019
After removing the 'Privacy notice' and 'Help' items from the Settings screen
the UI tests for them became unneeded.
ValentinTimisica added a commit that referenced this issue Dec 12, 2019
Added new items to be displayed.
ValentinTimisica added a commit that referenced this issue Dec 12, 2019
After removing the 'Privacy notice' and 'Help' items from the Settings screen
the UI tests for them became unneeded.
@project-bot project-bot bot moved this from In Dev Review to Ready for QA in Fenix Sprint Kanban Dec 12, 2019
@lobontiumira
Copy link

lobontiumira commented Dec 17, 2019

Hi all!
The design in Settings - About in the latest Nightly from 12/17 is:
Screenshot_20191217-105900

I've encountered an issue on Google Pixel (Android Q) regarding the "Privacy notice" page.

Thanks!

@lobontiumira lobontiumira removed the eng:qa:needed QA Needed label Dec 17, 2019
@project-bot project-bot bot moved this from Ready for QA to Sprint Backlog in Fenix Sprint Kanban Dec 17, 2019
@lobontiumira lobontiumira added the eng:qa:verified QA Verified label Dec 17, 2019
@project-bot project-bot bot moved this from Sprint Backlog to Sprint 12.2 Done in Fenix Sprint Kanban Dec 17, 2019
Fenix Q4 Feature Backlog automation moved this from Could to Done! Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Settings Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Help wanted from a contributor. More complex than good first issue.
Projects
No open projects
Development

No branches or pull requests