[Bug] Deleting opened tabs, exits Settings-Delete browsing data and returns to homescreen

[lobontiumira]

Steps to reproduce

1. Make sure to have at least 1 tab opened.
2. Go to Settings - Delete browsing data - select Open tabs and delete.

Expected behavior

The user should remain in Settings - Delete browsing data page, exactly like it does when deleting "Browsing history" and "Collections". Maybe it is a consequence of #4376.

Actual behavior

The user is redirected to the homescreen.

Device information

• Android device: Huawei P9 Lite (Android 6), Xiaomi Mi 8 Lite (Android 9)
• Fenix version: RC 1.3.0-rc.3

┆Issue is synchronized with this Jira Task

[mikeGolf08]

#4788 & #4642

[colintheshots]

I had UX sign off for this behavior in the case of deleted tabs. This is expected behavior. The problem is that the user could've left a deleted tab in the back stack that is invalid and the navigation library doesn't allow removing fragments from the back stack.

[lobontiumira]

@colintheshots just to be clear: when deleting "Browsing history" and "Collections" the user remains in the Settings-Delete browsing data page, but when deleting Open tabs, the user is redirected to the home screen?
Thank you!

[topotropic]

@AmyYLee I think you worked on it, could you have a look and see if it's expected behavior? Thanks!

[AmyYLee]

@softvision-miralobontiu @colintheshots

To be clear, deleting any listed items will take the user back to the Settings main screen.

[mcarare]

It currently navigates to home only if you open settings from the browser screen, as the current tab is closed.

[abodea]

Verified as fixed on the latest Beta build 4.0.0-beta.1 with Google Pixel 3a XL (Android 10).
Note that now the redirect is correctly made to the Settings main screen after deleting any listed items.