Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

UI nit picks:- Library screen #484

Closed
Cheap-Skate opened this issue Feb 13, 2019 · 1 comment
Closed

UI nit picks:- Library screen #484

Cheap-Skate opened this issue Feb 13, 2019 · 1 comment
Assignees
Labels
needs:UX-feedback Needs UX Feedback

Comments

@Cheap-Skate
Copy link

Cheap-Skate commented Feb 13, 2019

Nit 1:- in the Library screen the title text is left justified but in the History screen it is offset to the right by the back arrow ("<- History"). Could the text be in the same position horizontally on all these screens? Arguably the Library screen needs a back arrow to go back to Settings which would be a good way to fix?

Nit 2:- on the Library screen I dislike the horizontal dividing lines, I don't see what they add & they don't seem very "Android". They are not present on other screens & menus (e.g. History, Settings).

Thanks!

┆Issue is synchronized with this Jira Task

@pocmo pocmo added the needs:UX-feedback Needs UX Feedback label Feb 13, 2019
@brampitoyo
Copy link

@Cheap-Skate

Nit 1:- in the Library screen the title text is left justified but in the History screen it is offset to the right by the back arrow ("<- History"). Could the text be in the same position horizontally on all these screens?

The Library title text is left justified, because it’s the first page that you access from within the main menu ⋮. You can’t access our Library within Settings; if you can, then you’re right that there should be a back arrow.

Whereas History, Bookmarks, Logins, etc. all have back arrow ← because the page is one level inside the structure.

If you look at other Android apps (e.g. Messages, Chrome), you’ll see that the very first screen doesn’t have any back arrow, but every screen afterwards does. So we’re following a system convention here.

Action: I don’t recommend changing anything.

Nit 2:- on the Library screen I dislike the horizontal dividing lines […] They are not present on other screens & menus (e.g. History, Settings).

You are totally right on this one. If you’re running Android Pie, have a look at Android System Settings, and you’ll see that each menu item isn’t divided with a horizontal ruler.

Action: remove horizontal dividing lines on our Library screen.

Good catch! Thanks.

@topotropic topotropic self-assigned this Feb 20, 2019
@ekager ekager self-assigned this Feb 20, 2019
@ekager ekager added this to the Sprint 2-2 (Milestone 2) milestone Feb 20, 2019
ekager added a commit to ekager/fenix that referenced this issue Feb 20, 2019
@ghost ghost added in progress labels Feb 20, 2019
@ghost ghost removed in progress labels Feb 20, 2019
@bifleming bifleming moved this from To do to Done in Sprint 2.2 Backlog (Test) Feb 20, 2019
sblatz pushed a commit to sblatz/fenix that referenced this issue Feb 21, 2019
@bbinto bbinto added the size S label Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:UX-feedback Needs UX Feedback
Projects
No open projects
Development

No branches or pull requests

6 participants