You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Nit 1:- in the Library screen the title text is left justified but in the History screen it is offset to the right by the back arrow ("<- History"). Could the text be in the same position horizontally on all these screens? Arguably the Library screen needs a back arrow to go back to Settings which would be a good way to fix?
Nit 2:- on the Library screen I dislike the horizontal dividing lines, I don't see what they add & they don't seem very "Android". They are not present on other screens & menus (e.g. History, Settings).
Nit 1:- in the Library screen the title text is left justified but in the History screen it is offset to the right by the back arrow ("<- History"). Could the text be in the same position horizontally on all these screens?
The Library title text is left justified, because it’s the first page that you access from within the main menu ⋮. You can’t access our Library within Settings; if you can, then you’re right that there should be a back arrow.
Whereas History, Bookmarks, Logins, etc. all have back arrow ← because the page is one level inside the structure.
If you look at other Android apps (e.g. Messages, Chrome), you’ll see that the very first screen doesn’t have any back arrow, but every screen afterwards does. So we’re following a system convention here.
Action: I don’t recommend changing anything.
Nit 2:- on the Library screen I dislike the horizontal dividing lines […] They are not present on other screens & menus (e.g. History, Settings).
You are totally right on this one. If you’re running Android Pie, have a look at Android System Settings, and you’ll see that each menu item isn’t divided with a horizontal ruler.
Action: remove horizontal dividing lines on our Library screen.
Nit 1:- in the Library screen the title text is left justified but in the History screen it is offset to the right by the back arrow ("<- History"). Could the text be in the same position horizontally on all these screens? Arguably the Library screen needs a back arrow to go back to Settings which would be a good way to fix?
Nit 2:- on the Library screen I dislike the horizontal dividing lines, I don't see what they add & they don't seem very "Android". They are not present on other screens & menus (e.g. History, Settings).
Thanks!
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: