Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Customize the name of a shortcut #5047

Closed
NotWoods opened this issue Aug 30, 2019 · 8 comments
Closed

Customize the name of a shortcut #5047

NotWoods opened this issue Aug 30, 2019 · 8 comments
Assignees
@boek
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:HomescreenShortcuts bookmarks on the Android homescreen Feature:PWA Progressive Web App feature request 🌟 New functionality and improvements
Milestone
v2.0

Comments

@NotWoods
Copy link
Contributor

NotWoods commented Aug 30, 2019 •
edited by data-sync-user

Why/User Benefit/User Problem

Shortcuts and PWAs are similar but have some distinctions.

  • PWAs should run offline and must include a Web App Manifest. Their name is set by the manifest. They also have adaptive icons when pinned.
  • Shortcuts are like a bookmark but on the home screen. Their name is based on the page title but could be editable, just like a bookmark.

What/Requirements

-I can choose what the shortcut will be called (InVision)

Acceptance Criteria (how do I know when I’m done?)

Shortcuts can have custom names

┆Issue is synchronized with this Jira Task
@NotWoods NotWoods added the feature request 🌟 New functionality and improvements label Aug 30, 2019
@NotWoods NotWoods mentioned this issue Aug 30, 2019
Closed
@liuche
Copy link
Contributor

liuche commented Aug 30, 2019

@apbitner I think we could use some UX feedback here.

How should we differentiate between PWAs (with fixed names) vs homescreen shortctus to users?

@apbitner
Copy link

Here's what I have in my PWA designs, so it'd be a different dialog - https://mozilla.invisionapp.com/share/RGSCJEGJM8T#/366942530_Screens_-_PWA_-_Android_Add

@NotWoods
Copy link
Contributor Author

Since that screen is displayed by the system, it would also appear for shortcuts. Users would see two dialogs: entering the name, then pinning the shortcut.

@apbitner
Copy link

Regular site shortcuts will have the custom renaming dialog followed by the system dialog. And then PWA's will just have the system dialog.

@liuche
Copy link
Contributor

liuche commented Aug 30, 2019

Okay, so it sounds like we'll just accept the confusion a user might encounter if they can't tell what situations they see a rename dialog, vs not.

@liuche liuche added this to To be Triaged in Fenix Sprint Kanban via automation Sep 3, 2019
@boek boek added E5 Estimation Point: about 5 days Feature:HomescreenShortcuts bookmarks on the Android homescreen Feature:PWA Progressive Web App and removed needs:group-triage labels Sep 3, 2019
@liuche
Copy link
Contributor

liuche commented Sep 3, 2019

If we want to turn off the feature, it'd be an E2.

UX wants the feature to ship complete, so the two options are:

  • Turn off the feature, OR
  • Fix this bug

@liuche liuche moved this from To be Triaged to Prioritized Feature Backlog in Fenix Sprint Kanban Sep 3, 2019
@liuche liuche moved this from Prioritized Feature Backlog to Sprint Backlog in Fenix Sprint Kanban Sep 3, 2019
@boek boek self-assigned this Sep 3, 2019
@boek boek moved this from Sprint Backlog to In Progress in Fenix Sprint Kanban Sep 3, 2019
@boek boek mentioned this issue Sep 3, 2019
Closed
@boek boek added this to the v2.0 milestone Sep 4, 2019
boek added a commit to boek/fenix that referenced this issue Sep 11, 2019
@boek
For mozilla-mobile#5047 - Adjusts style for add to homescreen dialog
6711baa
boek added a commit to boek/fenix that referenced this issue Sep 11, 2019
@boek
For mozilla-mobile#5047 - Creates dialog ui for naming a shortcut
e933dd6
boek added a commit to boek/fenix that referenced this issue Sep 11, 2019
@boek
For mozilla-mobile#5047 - Wires up dialog to webAppUseCases
38ad8a2
boek added a commit to boek/fenix that referenced this issue Sep 11, 2019
@boek
For mozilla-mobile#5047 - Wires up dialog to webAppUseCases
b62d1e8
boek added a commit to boek/fenix that referenced this issue Sep 11, 2019
@boek
For mozilla-mobile#5047 - Wires up dialog to webAppUseCases
5268ab2
@boek boek moved this from In Progress to In Review in Fenix Sprint Kanban Sep 11, 2019
boek added a commit to boek/fenix that referenced this issue Sep 11, 2019
@boek
For mozilla-mobile#5047 - Addresses nits
84326fb 
- Changes MainScope to viewLifecycleScope
- Fixes string name/comment to better describe what it is
- Adds disabled state to the add button
boek added a commit to boek/fenix that referenced this issue Sep 11, 2019
@boek
For mozilla-mobile#5047 - Addresses nits
fcfaa4c 
- Changes MainScope to viewLifecycleScope
- Fixes string name/comment to better describe what it is
- Adds disabled state to the add button
boek added a commit that referenced this issue Sep 11, 2019
@boek
For #5047 - Creates dialog ui for naming a shortcut
faff73b
boek added a commit that referenced this issue Sep 11, 2019
@boek
For #5047 - Wires up dialog to webAppUseCases
d18ec49
boek added a commit that referenced this issue Sep 11, 2019
@boek
For #5047 - Addresses nits
e092dfd 
- Changes MainScope to viewLifecycleScope
- Fixes string name/comment to better describe what it is
- Adds disabled state to the add button
@ekager ekager added the eng:qa:needed QA Needed label Sep 12, 2019
@boek boek moved this from In Review to Ready for QA in Fenix Sprint Kanban Sep 12, 2019
@lobontiumira
Copy link

lobontiumira commented Sep 12, 2019 •
edited

Verified that the user can customize the name of a shortcut when using "Add to Home screen".
Tested on RC 2.0.0-rc.2 with Xiaomi Mi Pad 2 (Android 5.1) - x86 architecture, and OnePlus 5T (Android 9).

@boek
NOTE: the "Cancel" and "Add" buttons are not purple, are dark grey, on both devices.
Should I file an issue regarding this?

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 12, 2019
@project-bot project-bot bot moved this from Ready for QA to In Progress in Fenix Sprint Kanban Sep 12, 2019
@boek
Copy link
Contributor

boek commented Sep 12, 2019

@softvision-miralobontiu Good catch! I can fix here :)

@ekager ekager closed this as completed Sep 20, 2019
Fenix Sprint Kanban automation moved this from In Progress to Done Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@boek boek

Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:HomescreenShortcuts bookmarks on the Android homescreen Feature:PWA Progressive Web App feature request 🌟 New functionality and improvements
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
6 participants
@liuche @boek @NotWoods @apbitner @ekager @lobontiumira