Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

UI nit:- top search bar briefly turns into "full URL bar" when I hit enter key on keyboard #507

Closed
Cheap-Skate opened this issue Feb 14, 2019 · 4 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified

Comments

@Cheap-Skate
Copy link

Cheap-Skate commented Feb 14, 2019

Type some search text into the search bar (not a known URL, an actual Google search)
Hit enter on your keyboard
The search bar at the top of the screen briefly (quarter of a second?) turns into the full URL bar with the Google search URL in it including globe icon, tabs icon, 3 dot menu before returning to the bottom of the screen.

Perhaps it could be stopped doing this, it's a bit ugly (but not a massive issue).

This is a single frame grab from the sequence, it only lasts a short period of time

screenshot 2019-02-14 at 18 01 25

And here's a video from which the frame grab came

searchbar.mov.zip

Galaxy S7
Android 8.0.0

┆Issue is synchronized with this Jira Task

@ekager ekager added the 🐞 bug Crashes, Something isn't working, .. label Feb 14, 2019
@ekager
Copy link
Contributor

ekager commented Feb 14, 2019

I can reproduce on Pixel 3 by adding a small delay in transitionToBrowser(). Currently in BrowserToolbar, it enters display mode when the url is entered:

internal fun onUrlEntered(url: String) {
        displayMode()

        urlCommitListener?.invoke(url)
    }

@ekager
Copy link
Contributor

ekager commented Feb 15, 2019

Filed an issue to discuss with AC Team
mozilla-mobile/android-components#2077

@ekager
Copy link
Contributor

ekager commented Feb 15, 2019

@pocmo added more control to the toolbar urlCommitListener for this issue in AC so we will be able to update this next week. Thanks!!

@ekager ekager self-assigned this Feb 15, 2019
@ekager ekager added this to the Sprint 2-2 (Milestone 2) milestone Feb 15, 2019
@boek boek self-assigned this Feb 20, 2019
boek added a commit to boek/fenix that referenced this issue Feb 20, 2019
@bifleming bifleming moved this from Done to In progress in Sprint 2.2 Backlog (Test) Feb 20, 2019
@ghost ghost added in progress labels Feb 21, 2019
boek added a commit to boek/fenix that referenced this issue Feb 21, 2019
@boek boek closed this as completed Feb 21, 2019
@ghost ghost removed in progress labels Feb 21, 2019
@bbinto bbinto added the size S label Feb 22, 2019
@bifleming bifleming moved this from In progress to Done in Sprint 2.2 Backlog (Test) Feb 25, 2019
@sv-ohorvath sv-ohorvath added the eng:qa:verified QA Verified label Feb 28, 2019
@sv-ohorvath
Copy link
Contributor

Could reproduce this and now it's verified as fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
No open projects
Development

No branches or pull requests

5 participants