Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Search engine selection is awkward with Talkback #5142

Closed
asadotzler opened this issue Sep 5, 2019 · 1 comment
Closed

[Bug] Search engine selection is awkward with Talkback #5142

asadotzler opened this issue Sep 5, 2019 · 1 comment
Assignees
@mcarare
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search Feature:Settings
Milestone
v2.0

Comments

@asadotzler
Copy link

asadotzler commented Sep 5, 2019 •
edited by data-sync-user

Steps to reproduce

Launch Fenix with Talkback running.
Navigate to menu -> Settings -> Search engine
Swipe through search engine list

Expected behavior

One "activate" option for each search engine listed.

Actual behavior

For each search engine there is a button and a radio button that can both be focused and used to activate that engine

Device information

  • Android device: ? Samsung Galaxy S10e running Android 9
  • Fenix version: ? 190905

┆Issue is synchronized with this Jira Task
@asadotzler asadotzler added 🐞 bug Crashes, Something isn't working, .. access Accessibility: Talkback, HW keyboard/mouse, braile display etc. labels Sep 5, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Sep 6, 2019
@mcarare
For mozilla-mobile#5142 Removed RadioButton from accessibility keepin…
e2ee09b 
…g one option for Talkback

Set android:importantForAccessibility = "no" for RadioButton
@mcarare mcarare self-assigned this Sep 6, 2019
pocmo pushed a commit that referenced this issue Sep 6, 2019
@mcarare @pocmo
For #5142 Removed RadioButton from accessibility keeping one option f…
c8d622c 
…or Talkback

Set android:importantForAccessibility = "no" for RadioButton
@mcarare mcarare added the eng:qa:needed QA Needed label Sep 9, 2019
@jyeontaek jyeontaek added this to the v2.0 milestone Sep 12, 2019
@lobontiumira
Copy link

Verified as fixed on RC 2.0.0-rc.2 with Samsung Galaxy Tab S3 (Android 8), and OnePlus 5T (Android 9).

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search Feature:Settings
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
5 participants
@kbrosnan @asadotzler @jyeontaek @lobontiumira @mcarare