Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Find in page makes the QAB buttons visible #5174

Closed
AndiAJ opened this issue Sep 9, 2019 · 2 comments
Closed

[Bug]Find in page makes the QAB buttons visible #5174

AndiAJ opened this issue Sep 9, 2019 · 2 comments
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering help wanted Help wanted from a contributor. More complex than good first issue. P3 Some future sprint S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Milestone
v2.1

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Sep 9, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Navigate to any webpage
  2. From the 3dot menu button tap on "Find in page"
  3. Observe the QAB

Expected behavior

QAB is fully closed the buttons aren't visible

Actual behavior

QAB is crack open making the buttons partially visible

Device information

  • Android device:
    • Google Pixel 3a (Android 9)
    • Huawei Mate 20 Lite (Android 8.1.0)
    • Samsung Galaxy S7 (Android 7)
    • OnePlus A3 (Android 6.0.1)
    • LG Nexus 4 (Android 5.1.1)

  • Fenix version: Nightly Build #12520610 from 9/9

Notes

Quite similar with #2245

►Video
20190909_171309

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. Feature:QuickActionSheet S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Sep 9, 2019
@ekager
Copy link
Contributor

ekager commented Sep 12, 2019

We could probably hide the QAB while the user is using FIP

@ekager ekager added P3 Some future sprint help wanted Help wanted from a contributor. More complex than good first issue. eng:ready Ready for engineering labels Sep 12, 2019
@mcarare mcarare self-assigned this Sep 17, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Sep 17, 2019
@mcarare
For mozilla-mobile#5174 Changed FindInPage height to toolbar height t…
e01d75b 
…o cover QAB
Amejia481 pushed a commit that referenced this issue Sep 17, 2019
@mcarare @Amejia481
For #5174 Changed FindInPage height to toolbar height to cover QAB (#…
1767bd5 
…5376)
@mcarare mcarare added the eng:qa:needed QA Needed label Sep 19, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 20, 2019
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Sep 20, 2019

Hi, verified as fixed on Nightly Build #12621819 from 19/9 using the following devices:
• Google Pixel 3a (Android 9)
• Samsung Galaxy Note 9 (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

►Video
20190920_144713

@AndiAJ AndiAJ closed this as completed Sep 20, 2019
@sblatz sblatz modified the milestones: 2.1, v2.1 Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering help wanted Help wanted from a contributor. More complex than good first issue. P3 Some future sprint S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
4 participants
@sblatz @ekager @mcarare @AndiAJ