Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Build Instruction in README is out-of-date #5200

Closed
orionlee opened this issue Sep 10, 2019 · 1 comment
Closed

[Bug] Build Instruction in README is out-of-date #5200

orionlee opened this issue Sep 10, 2019 · 1 comment
Assignees
@colintheshots
Labels
🐞 bug Crashes, Something isn't working, ..
Milestone
v2.0

Comments

@orionlee
Copy link

orionlee commented Sep 10, 2019 •
edited by data-sync-user

The build instruction in README is out-of-date

  • ./gradlew clean app:assembleArmDebug - task app:assembleArmDebug no longer exists
  • build variant instruction for Android Studio is similarly outdated
  • it'd be nice to call out Android NDK is required, in addition to SDK

The following is a strawman changes to build instructions, with open issues marked with OPEN

Build Instructions

Note: Both Android SDK and NDK are required.

  1. Clone or Download the repository:
git clone https://github.com/mozilla-mobile/fenix
  1. Import the project into Android Studio or build on the command line:
# OPEN: For newbie to the project should it use app:assembleDebug, app:assembleGeckoBetaDebug, or app:assembleGeckoNightlyDebug
./gradlew clean app:assembleDebug
  1. Make sure to select the correct build variant in Android Studio:
    geckoNightlyDebug for app module (OPEN: or should it be geckoBetaDebug)

┆Issue is synchronized with this Jira Task
@orionlee orionlee added the 🐞 bug Crashes, Something isn't working, .. label Sep 10, 2019
colintheshots added a commit to colintheshots/fenix that referenced this issue Sep 11, 2019
@colintheshots
For mozilla-mobile#5200: Update build docs to reflect new variants
a400897
colintheshots added a commit to colintheshots/fenix that referenced this issue Sep 11, 2019
@colintheshots
For mozilla-mobile#5200: Update build docs to reflect new variants
fa06e43
colintheshots added a commit to colintheshots/fenix that referenced this issue Sep 11, 2019
@colintheshots
For mozilla-mobile#5200: Update build docs to reflect new variants
8a26834
colintheshots added a commit that referenced this issue Sep 11, 2019
@colintheshots
For #5200: Update build docs to reflect new variants (#5220)
bfee95b 
* For #5200: Update build docs to reflect new variants

* Added a description of the build variants

* Added data loss warning
@colintheshots colintheshots added this to To be Triaged in Fenix Sprint Kanban via automation Sep 11, 2019
@colintheshots colintheshots added this to the v2.0 milestone Sep 11, 2019
@colintheshots colintheshots moved this from To be Triaged to Done in Fenix Sprint Kanban Sep 11, 2019
@colintheshots colintheshots self-assigned this Sep 11, 2019
@sblatz
Copy link
Contributor

sblatz commented Sep 11, 2019

@colintheshots should this actually be in the done column?

@ekager ekager closed this as completed Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@colintheshots colintheshots

Labels
🐞 bug Crashes, Something isn't working, ..
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
4 participants
@orionlee @colintheshots @sblatz @ekager