Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Transition to PB isn't made after sharing a page from normal to private browsing #5254

Closed
AndiAJ opened this issue Sep 12, 2019 · 2 comments
Closed

[Bug]Transition to PB isn't made after sharing a page from normal to private browsing #5254

AndiAJ opened this issue Sep 12, 2019 · 2 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Sharing S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Milestone
v2.1

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Sep 12, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Navigate to any webpage
  2. From the QAB tap on Share
  3. Select "Firefox Preview (Private)"rsz_screenshot_20190912-104555_fireaaaaaaaaaaaaaaaaaaaaafox_preaaaaview

Expected behavior

After sharing the transition to Private Browsing should be made

Actual behavior

No transition to PB, the user remains in Normal browsing

Device information

  • Android device: Samsung Galaxy Tab A (Android 9)
  • Fenix version: 2.0.0-cr.2 (Build #12550444)

Notes

Similar with #5033 & #4772

►Video
20190912_104814 (1)

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist Feature:Sharing labels Sep 12, 2019
jyeontaek added a commit to jyeontaek/fenix that referenced this issue Sep 12, 2019
@jyeontaek
For mozilla-mobile#5254: Fix transition to private browsing mode afte…
0e3145f 
…r sharing a page
jyeontaek added a commit to jyeontaek/fenix that referenced this issue Sep 12, 2019
@jyeontaek
For mozilla-mobile#5254: Fix transition to private browsing mode afte…
cb78585 
…r sharing a page
jyeontaek added a commit to jyeontaek/fenix that referenced this issue Sep 12, 2019
@jyeontaek
For mozilla-mobile#5254: Fix transition to private browsing mode afte…
df5d1b6 
…r sharing a page
@jyeontaek jyeontaek self-assigned this Sep 13, 2019
@jyeontaek jyeontaek added this to the v2.0 milestone Sep 13, 2019
@jyeontaek jyeontaek added this to In Progress in Fenix Sprint Kanban Sep 13, 2019
@vrudesai vrudesai mentioned this issue Sep 13, 2019
Closed
6 tasks
ekager pushed a commit that referenced this issue Sep 13, 2019
@jyeontaek @ekager
For #5254: Fix transition to private browsing mode after sharing a page
3787dd7
@ekager ekager added the eng:qa:needed QA Needed label Sep 13, 2019
@sblatz sblatz moved this from In Progress to In Review in Fenix Sprint Kanban Sep 16, 2019
@sblatz sblatz moved this from In Review to Ready for QA in Fenix Sprint Kanban Sep 16, 2019
boek pushed a commit that referenced this issue Sep 16, 2019
@jyeontaek @boek
For #5254: Fix transition to private browsing mode after sharing a page
15c6ba8
@lobontiumira
Copy link

This issue might be related: 5375.

@abodea
Copy link
Member

abodea commented Sep 17, 2019

Verified as fixed on the Fenix v2.0.0-rc3 using OnePlus 6T(Android 9), Samsung Galaxy S10+(Android 9), Google Pixel 3a (Android 9), Google Nexus 7 II(Android 5.1.1), OnePlus 3(Android 6.0.1).

@abodea abodea closed this as completed Sep 17, 2019
Fenix Sprint Kanban automation moved this from Ready for QA to Done Sep 17, 2019
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 17, 2019
@project-bot project-bot bot moved this from Done to In Progress in Fenix Sprint Kanban Sep 17, 2019
@abodea abodea moved this from In Progress to Done in Fenix Sprint Kanban Sep 17, 2019
@sblatz sblatz modified the milestones: v2.0, v2.1 Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Sharing S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
6 participants
@sblatz @jyeontaek @ekager @lobontiumira @abodea @AndiAJ