Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]share sheet doesn't hide when touched on translucent area #5421

Closed
Scripterr opened this issue Sep 19, 2019 · 1 comment
Closed

[Bug]share sheet doesn't hide when touched on translucent area #5421

Scripterr opened this issue Sep 19, 2019 · 1 comment
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Milestone
v2.1

Comments

@Scripterr
Copy link

Scripterr commented Sep 19, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open a webpage.
  2. Select share option from QAB.
  3. Now click on the translucent area, from where you can see webpage.

Expected behavior

The share sheet hide out of view and web page can be full seen.

Actual behavior

Share sheet doesn't hide from clicking on the translucent area.

Device information

  • Android device: 8.0.0
  • Fenix version: Nightly 190918 18:01 (Build #12611806)
    📦: 13.0.0, 3cb2ac19c
    🦎: 71.0a1-20190916093313

Note:

This look like a regression because before you can use this feature.

┆Issue is synchronized with this Jira Task
@Scripterr Scripterr added the 🐞 bug Crashes, Something isn't working, .. label Sep 19, 2019
@ekager ekager self-assigned this Sep 20, 2019
ekager added a commit to ekager/fenix that referenced this issue Sep 20, 2019
@ekager
For mozilla-mobile#5421 - Make share dialog scrim dismiss fragment
3d53203
ekager added a commit that referenced this issue Sep 20, 2019
@ekager
For #5421 - Make share dialog scrim dismiss fragment
464122f
@ekager ekager added the eng:qa:needed QA Needed label Sep 20, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 23, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Sep 23, 2019

Hi, verified as fixed on Nightly build #12651809 from 22/9 using the following devices:
• Google Pixel 3a (Android 9)
• Samsung Galaxy Note 9 (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Video
20190923_124926

@AndiAJ AndiAJ closed this as completed Sep 23, 2019
@sblatz sblatz added this to the v2.1 milestone Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
4 participants
@sblatz @ekager @Scripterr @AndiAJ