Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

overflow menu for multitasking mixes regular and private sessions #545

Closed
cadeyrn opened this issue Feb 15, 2019 · 3 comments
Closed

overflow menu for multitasking mixes regular and private sessions #545

cadeyrn opened this issue Feb 15, 2019 · 3 comments
Assignees
@colintheshots
Labels
eng:qa:verified QA Verified
Projects
Sprint 2.2 Backlog (Test)
Milestone
Sprint 2-2 (Miles...

Comments

@cadeyrn
Copy link
Contributor

cadeyrn commented Feb 15, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. open a website A in a non-private session
  2. switch to the private mode
  3. open a website B in a private session
  4. switch between private and non-private mode
  5. click the button for the "current session" overflow menu
  6. delete the sesion

Expected / Actual behavior

Step 4: As expected: the non-private session shows only website A, the private session shows only website B.

Step 5: Unexpected: The dialog shows both website A and website B under the "current session" headline

Step 6: Deleting the session closes both the private as well as the non-private tab.

Device information

  • Android device: HTC U11 w/ Android 8.0.0
  • Fenix version: Fenix revision 8293f6a

┆Issue is synchronized with this Jira Task
@colintheshots colintheshots self-assigned this Feb 16, 2019
@colintheshots
Copy link
Contributor

At the time I started building this, private mode was not implemented yet. I'm on it.

colintheshots added a commit to colintheshots/fenix that referenced this issue Feb 16, 2019
@colintheshots
Fixes mozilla-mobile#545: overflow menu for multitasking mixes regula…
4a93a0c 
…r and private
@ghost ghost added in progress labels Feb 16, 2019
@boek boek closed this as completed in 0382665 Feb 17, 2019
@ghost ghost removed in progress labels Feb 17, 2019
@cadeyrn
Copy link
Contributor Author

cadeyrn commented Feb 17, 2019

For the record: 0382665 fixed step 5 but not step 6. The "delete" button still deletes sessions from both modes.

@colintheshots colintheshots reopened this Feb 17, 2019
colintheshots added a commit to colintheshots/fenix that referenced this issue Feb 17, 2019
@colintheshots
Fixes mozilla-mobile#545: overflow menu multitasking deletes private …
8a7ccd3 
…and non-private
@ghost ghost added in progress labels Feb 17, 2019
@ghost ghost removed in progress labels Feb 18, 2019
@sv-ohorvath
Copy link
Contributor

Verified as fixed.

@sv-ohorvath sv-ohorvath added the eng:qa:verified QA Verified label Feb 20, 2019
@bifleming bifleming moved this from To do to Done in Sprint 2.2 Backlog (Test) Feb 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@colintheshots colintheshots

Labels
eng:qa:verified QA Verified
Projects
No open projects
Sprint 2.2 Backlog (Test)
  
Done
Milestone
Sprint 2-2 (Milestone 2)
Development

No branches or pull requests
3 participants
@colintheshots @cadeyrn @sv-ohorvath