Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Share function on slide-up menu provides old url after switching tab via notification #5568

Closed
hwinnemoe opened this issue Sep 25, 2019 · 2 comments
Closed

[Bug] Share function on slide-up menu provides old url after switching tab via notification #5568

hwinnemoe opened this issue Sep 25, 2019 · 2 comments
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Milestone
v2.1

Comments

@hwinnemoe
Copy link

hwinnemoe commented Sep 25, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open a website, e.g. https://www.mozilla.org/en-GB/.
  2. Long-press on a link, e.g. https://www.mozilla.org/en-GB/firefox/accounts/, and choose "Open link in new tab".
  3. Switch to the new tab using "SWITCH" on the "New tab opened" notification.
  4. Share the link using the share function in the slide-up menu.

Expected behavior

The current tab's url is shared, in this case https://www.mozilla.org/en-GB/firefox/accounts/.

Actual behavior

The previous tab's url is shared, in this case https://www.mozilla.org/en-GB/. This might be the same or related to issue #5032.

Device information

  • Android device: Sony Xperia Z2, Android 6.0.1
  • Fenix version:
    "Nightly 190924 12:53" (Build #12671258)
    📦: 14.0.0, 186fa2396
    GV: 71.0a1-20190923094800

┆Issue is synchronized with this Jira Task
@hwinnemoe hwinnemoe added the 🐞 bug Crashes, Something isn't working, .. label Sep 25, 2019
@hwinnemoe hwinnemoe changed the title [Bug] Share funtion on slide-up menu provides old url after switching tab via notification [Bug] Share function on slide-up menu provides old url after switching tab via notification Sep 25, 2019
@ekager
Copy link
Contributor

ekager commented Sep 25, 2019 •
edited
Loading

The DefaultQuickActionSheetController uses a passed in Session that must not be updating correctly.

@ekager ekager self-assigned this Sep 25, 2019
ekager added a commit to ekager/fenix that referenced this issue Sep 25, 2019
@ekager
For mozilla-mobile#5568 - Don't pass in Session for QuickActionSheetC…
db0ab96 
…ontroller
ekager added a commit to ekager/fenix that referenced this issue Sep 25, 2019
@ekager
For mozilla-mobile#5568 - Don't pass in Session for QuickActionSheetC…
589ca14 
…ontroller
ekager added a commit that referenced this issue Sep 25, 2019
@ekager
For #5568 - Don't pass in Session for QuickActionSheetController
24b3ed4
@ekager ekager added the eng:qa:needed QA Needed label Sep 25, 2019
@ekager ekager added this to the v2.1 milestone Sep 25, 2019
@ekager ekager added this to To be Triaged in Fenix Sprint Kanban via automation Sep 25, 2019
@ekager ekager moved this from To be Triaged to Ready for QA in Fenix Sprint Kanban Sep 25, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 27, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Sep 27, 2019

Hi, verified as fixed on Nightly Build #12700627 from 27/9 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Video
20190927_115741

@AndiAJ AndiAJ closed this as completed Sep 27, 2019
Fenix Sprint Kanban automation moved this from Ready for QA to Done Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
3 participants
@ekager @hwinnemoe @AndiAJ