Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Crash on custom tabs menu if no other tabs are open #568

Closed
colintheshots opened this issue Feb 17, 2019 · 1 comment
Closed

Crash on custom tabs menu if no other tabs are open #568

colintheshots opened this issue Feb 17, 2019 · 1 comment
Assignees
@colintheshots
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
Sprint 2.2 Backlog (Test)
Milestone
Sprint 2-2 (Miles...

Comments

@colintheshots
Copy link
Contributor

colintheshots commented Feb 17, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Swipe away Fenix if opened.
  2. Open a custom tab from Slack.
  3. Press 3 dots overflow menu.

Expected behavior

Menu opens.

Actual behavior

App crashes because selectedSession is null in selectedSessionOrThrow.

Device information

  • Android device: Samsung Galaxy S8
  • Fenix version: Master, built Feb 15th

┆Issue is synchronized with this Jira Task
@colintheshots colintheshots self-assigned this Feb 17, 2019
@colintheshots colintheshots added the 🐞 bug Crashes, Something isn't working, .. label Feb 17, 2019
colintheshots added a commit to colintheshots/fenix that referenced this issue Feb 17, 2019
@colintheshots
Fixes mozilla-mobile#568: Crash on custom tabs menu if no other tabs …
df3a2c2 
…are open
@ghost ghost added in progress labels Feb 17, 2019
@boek boek closed this as completed in 66ebb65 Feb 18, 2019
@ghost ghost removed in progress labels Feb 18, 2019
@bifleming bifleming added this to In progress in Sprint 2.2 Backlog (Test) Feb 20, 2019
@bifleming bifleming moved this from In progress to Done in Sprint 2.2 Backlog (Test) Feb 20, 2019
@bbinto bbinto added the size S label Feb 22, 2019
@bsurd bsurd added the eng:qa:verified QA Verified label Mar 6, 2019
@bsurd
Copy link

bsurd commented Mar 6, 2019

Verified by opening custom tabs from different applications following the steps provided, Fenix did not crash.

Verified on:

  • 1.0.1910 (Build #10642115)

Devices:

  • Nokia 6 (Android 7.1.1)
  • HTC Desire 820 (Android 6.0.1)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@colintheshots colintheshots

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
No open projects
Sprint 2.2 Backlog (Test)
  
Done
Milestone
Sprint 2-2 (Milestone 2)
Development

No branches or pull requests
3 participants
@bbinto @colintheshots @bsurd