This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
[Bug] UI tests continue with false positive on mDevice.wait #6031
Assignees
Labels
🐞 bug
Crashes, Something isn't working, ..
eng:automation
Build automation, Continuous integration, ..
Comments
rpappalax
added
🐞 bug
|
I'll take this and adjust the timeout delay too. |
AaronMT
changed the title
AaronMT
added a commit
to AaronMT/fenix
that referenced
this issue
Oct 17, 2019
…er check See mozilla-mobile#6031 - Adjust waits with assert check - Adjusts timer to speed things up - Test fix and cleanup
AaronMT
added a commit
to AaronMT/fenix
that referenced
this issue
Oct 21, 2019
…er check See mozilla-mobile#6031 - Adjust waits with assert check - Adjusts timer to speed things up - Test fix and cleanup fix: review comments - fixed proper resource name selectors - re-added waits for slow devices
AaronMT
added a commit
to AaronMT/fenix
that referenced
this issue
Oct 21, 2019
…er check See mozilla-mobile#6031 - Adjust waits with assert check - Adjusts timer to speed things up - Test fix and cleanup fix: review comments - fixed proper resource name selectors - re-added waits for slow devices fix: ktlint
AaronMT
added a commit
to AaronMT/fenix
that referenced
this issue
Oct 22, 2019
…er check See mozilla-mobile#6031 - Adjust waits with assert check - Adjusts timer to speed things up - Test fix and cleanup fix: review comments - fixed proper resource name selectors - re-added waits for slow devices fix: ktlint
mcarare
pushed a commit
to mcarare/fenix
that referenced
this issue
Oct 29, 2019
…er check (mozilla-mobile#6084) See mozilla-mobile#6031 - Adjust waits with assert check - Adjusts timer to speed things up - Test fix and cleanup fix: review comments - fixed proper resource name selectors - re-added waits for slow devices fix: ktlint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently for UI tests, we are using
mDevice.wait(Untilto wait until a UI element is present. However, this operation by itself will only wait until the object is found or until the end of the wait period specified. Without an assert to determine if the element was found or not, the test will proceed with a false positive result.per @npark-mozilla, mDevice.wait will not fail the test, it’ll only time out. you need to wrap it with Assert to get something to fail, see: UIDevice
We should use the return value, returns: The final result returned by the condition, or null if the condition was not met before the timeout.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: