Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Update copy and graphic on QR scanning screen #6198

Closed
lime124 opened this issue Oct 22, 2019 · 8 comments
Closed

Update copy and graphic on QR scanning screen #6198

lime124 opened this issue Oct 22, 2019 · 8 comments
Assignees
@mcarare
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering P3 Some future sprint
Projects
4.2

Comments

@lime124
Copy link
Collaborator

lime124 commented Oct 22, 2019 •
edited by data-sync-user
Loading

Pulled from A/C:
mozilla-mobile/android-components#4261

Please update graphic (zip file in above A/C issue). We've also dropped the https for legibility.

┆Issue is synchronized with this Jira Task
@lime124 lime124 added eng:ready Ready for engineering Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Help wanted from a contributor. More complex than good first issue. labels Oct 22, 2019
@NotWoods NotWoods mentioned this issue Oct 23, 2019
Closed
@KMaragh
Copy link
Contributor

KMaragh commented Oct 24, 2019 •
edited
Loading

@lime124 @NotWoods Mind if I pick this up? :)

Edit: Looks like it may already be assigned to someone else and is no longer available?

@NotWoods
Copy link
Contributor

Hi @KMaragh, unfortunately this ticket has already been picked up in the Android Components repository and I don't think there will be much additional work. Check out our Hacktoberfest issues for other options 😄

@KMaragh
Copy link
Contributor

KMaragh commented Oct 24, 2019

@NotWoods I will! Thanks :)

@boek
Copy link
Contributor

boek commented Dec 28, 2019

Waiting on mozilla-mobile/android-components#4845

@boek boek added P3 Some future sprint 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Dec 28, 2019
@mcarare mcarare removed the Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! label Mar 17, 2020
@mcarare mcarare self-assigned this Mar 17, 2020
@mcarare mcarare added this to doing in 4.2 Mar 18, 2020
@mcarare
Copy link
Contributor

mcarare commented Mar 18, 2020

Should we also lock screen orientation like it was suggested here: #7132 ?

@vesta0
Copy link
Collaborator

vesta0 commented Mar 29, 2020

@mcarare I don't think so - is there a reason we'd want to do that?

@mcarare mcarare added the needs:UX-feedback Needs UX Feedback label Apr 14, 2020
mcarare added a commit to mcarare/fenix that referenced this issue May 25, 2020
@mcarare
For mozilla-mobile#6198: Update copy and position of pair QR code sca…
cad84c4 
…n message.
mcarare added a commit to mcarare/fenix that referenced this issue May 25, 2020
@mcarare
For mozilla-mobile#6198: Update copy and position of pair QR code sca…
b049f3a 
…n message.
mcarare added a commit to mcarare/fenix that referenced this issue May 25, 2020
@mcarare
For mozilla-mobile#6198: Update copy and position of pair QR code sca…
be843ec 
…n message.
jonalmeida pushed a commit that referenced this issue May 25, 2020
@mcarare @jonalmeida
For #6198: Update copy and position of pair QR code scan message.
6e325d6
@mcarare mcarare removed needs:UX-feedback Needs UX Feedback 🙅 waiting Issues that are blocked or has dependencies that are not ready labels May 26, 2020
@mcarare mcarare closed this as completed May 26, 2020
@mcarare mcarare removed the help wanted Help wanted from a contributor. More complex than good first issue. label May 26, 2020
@mcarare mcarare moved this from doing to done in 4.2 May 26, 2020
@mcarare mcarare moved this from done to ready for qa in 4.2 May 26, 2020
@mcarare mcarare added the eng:qa:needed QA Needed label May 26, 2020
@mcarare mcarare reopened this May 26, 2020
@LaurentiuApahideanSV
Copy link

Verified as fixed on Firefox Preview Beta 5.1.0-beta.2 and Nightly 200529 (Build #21500608) 5/29 using a OnePlus 6T (Android 9) and Huawei MediaPad M3 lite (Android 7.0). The QR code screen is according to the one found in mozilla-mobile/android-components#4261.

@mcarare
Copy link
Contributor

mcarare commented Jun 2, 2020

Closing as per comment above.

@mcarare mcarare closed this as completed Jun 2, 2020
@liuche liuche mentioned this issue Jun 10, 2020
Closed
29 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
eng:qa:verified QA Verified eng:ready Ready for engineering P3 Some future sprint
Projects
No open projects
4.2
ready for qa
Milestone
No milestone
Development

No branches or pull requests
7 participants
@lime124 @boek @NotWoods @KMaragh @vesta0 @mcarare @LaurentiuApahideanSV