Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Incorrect Leanplum push message check (may be causing crashes) #6250

Closed
jonalmeida opened this issue Oct 24, 2019 · 0 comments · Fixed by #8069
Closed

[Bug] Incorrect Leanplum push message check (may be causing crashes) #6250

jonalmeida opened this issue Oct 24, 2019 · 0 comments · Fixed by #8069
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Telemetry P2 Upcoming release

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Oct 24, 2019

Currently, the checks in FirebasePush for LeanPlum are not consistent with what the LeanPlum SDK checks for. This maybe the cause for mozilla-mobile/android-components#4736.

Alternatively, we should follow what the Leanplum docs suggest having a separate service for receiving messages.

┆Issue is synchronized with this Jira Task

@jonalmeida jonalmeida added the 🐞 bug Crashes, Something isn't working, .. label Oct 24, 2019
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Oct 24, 2019
This reverts commit ed239ec.

We're choosing to revert LeanPlum push messaging integration since we believe
that this has introduced a crash in Firebase push messaging. To verify
this assumption we're reverting this change, and when confirmed, we can
re-introduce Leamplum in a safer manner.

See mozilla-mobile#6250 and mozilla-mobile#6251 for related info.
jonalmeida added a commit that referenced this issue Oct 25, 2019
This reverts commit ed239ec.

We're choosing to revert LeanPlum push messaging integration since we believe
that this has introduced a crash in Firebase push messaging. To verify
this assumption we're reverting this change, and when confirmed, we can
re-introduce Leamplum in a safer manner.

See #6250 and #6251 for related info.
mcarare pushed a commit to mcarare/fenix that referenced this issue Oct 29, 2019
This reverts commit ed239ec.

We're choosing to revert LeanPlum push messaging integration since we believe
that this has introduced a crash in Firebase push messaging. To verify
this assumption we're reverting this change, and when confirmed, we can
re-introduce Leamplum in a safer manner.

See mozilla-mobile#6250 and mozilla-mobile#6251 for related info.
@boek boek added Feature:Telemetry P2 Upcoming release labels Dec 28, 2019
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Jan 23, 2020
Also closes mozilla-mobile#6250, since we rely solely on the SDK itself to consume the
messages straight from FCM.
boek pushed a commit to boek/fenix that referenced this issue Feb 3, 2020
Also closes mozilla-mobile#6250, since we rely solely on the SDK itself to consume the
messages straight from FCM.
@boek boek closed this as completed in #8069 Feb 3, 2020
boek pushed a commit that referenced this issue Feb 3, 2020
Also closes #6250, since we rely solely on the SDK itself to consume the
messages straight from FCM.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Telemetry P2 Upcoming release
Projects
None yet
2 participants