Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Meta] Web Content Dark Mode #627

Closed
yoasif opened this issue Feb 21, 2019 · 6 comments
Closed

[Meta] Web Content Dark Mode #627

yoasif opened this issue Feb 21, 2019 · 6 comments
Assignees
Labels
eng:qa:verified QA Verified needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org

Comments

@yoasif
Copy link
Contributor

yoasif commented Feb 21, 2019

Why/User Benefit/User Problem

Users want a dark mode that changes web page contents and will switch browsers to get it.

See:

What / Requirements

  • Option in Fenix UI to change page contents to dark mode.
  • Ideally, it would use prefers color scheme
  • falling back to something closer to provided by Dark Background and Light Text or the modes in Kiwi or Samsung browsers

Acceptance Criteria (how do I know when I’m done?)

User can select a enable "night mode" in settings and have page contents changed based on this preference.

May be a dupe of #252 - unclear whether that is for theming or page contents.

This is possibly being introduced in Chrome: https://chromium-review.googlesource.com/c/chromium/src/+/1478106

┆Issue is synchronized with this Jira Task

@BlindMoon38
Copy link

I was thinking about requesting this as an accessibility feature. In desktop Firefox, if a high-contrast theme is active on Windows, Firefox acts accordingly and displays web content in high contrast. Since Android doesn't provide this option, an add-on is needed to emulate the feature in current Firefox for Android, which generates some quite inconvenient disadvantages...

@cpeterso cpeterso added GV67 needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org labels Feb 22, 2019
@cpeterso
Copy link

cpeterso commented Feb 22, 2019

GeckoView will need a new API for Fenix's dark mode setting to tell Gecko to enable CSS dark mode (aka prefers-color-scheme media feature):

https://bugzilla.mozilla.org/show_bug.cgi?id=1529972

@bbinto bbinto added the Epic label Mar 18, 2019
@bbinto bbinto changed the title Web Contents Dark Mode [Meta] Web Contents Dark Mode Mar 18, 2019
@bbinto
Copy link
Contributor

bbinto commented Mar 18, 2019

As per comment, we might pull this back into a Battery saving story after MVP.

Out of scope for MVP.

@bbinto bbinto added this to the Backlog (After MVP) milestone Mar 18, 2019
@bbinto bbinto added the could label Mar 18, 2019
@vesta0 vesta0 removed P2 Upcoming release needs:product GV67 labels Mar 28, 2019
@ekager ekager self-assigned this Apr 5, 2019
ekager added a commit to ekager/fenix that referenced this issue Apr 5, 2019
ekager added a commit to ekager/fenix that referenced this issue Apr 5, 2019
@ekager
Copy link
Contributor

ekager commented Apr 8, 2019

We are now using the PreferredColorScheme feature in GV when in Fenix dark mode. Is there an action item for this bullet?

  • falling back to something closer to provided by Dark Background and Light Text or the modes in Kiwi or Samsung browsers

@ekager ekager added the eng:qa:needed QA Needed label Apr 8, 2019
@ekager
Copy link
Contributor

ekager commented Apr 8, 2019

A good website to test the reactive dark theme in action is https://kevinchen.co/blog/support-macos-mojave-dark-mode-on-websites/

@vesta0 vesta0 changed the title [Meta] Web Contents Dark Mode [Meta] Dark Mode Apr 10, 2019
@vesta0 vesta0 changed the title [Meta] Dark Mode [Meta] Web Content Dark Mode Apr 10, 2019
@vesta0 vesta0 modified the milestones: MVP Metas, Post-MVP Metas Apr 10, 2019
@bsurd bsurd removed the eng:qa:needed QA Needed label Apr 19, 2019
@kbrosnan kbrosnan added the eng:qa:verified QA Verified label Apr 29, 2019
@kbrosnan
Copy link
Contributor

This is complete. Opening a feature request for forcing a dark mode as #2139.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org
Projects
None yet
Development

No branches or pull requests

8 participants