Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Changing Locale Does Not Update Search Engines #6907

Closed
ekager opened this issue Dec 2, 2019 · 5 comments
Closed

[Bug] Changing Locale Does Not Update Search Engines #6907

ekager opened this issue Dec 2, 2019 · 5 comments
Assignees
@boek
Labels
🐞 bug Crashes, Something isn't working, .. Feature:SearchProvider P2 Upcoming release S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill
Projects
Feature Polish

Comments

@ekager
Copy link
Contributor

ekager commented Dec 2, 2019 •
edited by data-sync-user

Steps to reproduce

  1. Have phone in 1 locale
  2. Open search engine settings, observe default "installed" engines
  3. Change locale
  4. Observe search engine settings

Expected behavior

Default installed engines (and default?) are updated with locale

Actual behavior

First locale "locks" in search engines in our saved file

Device information

  • Android device: ?
  • Fenix version: ?

┆Issue is synchronized with this Jira Task
@ekager ekager added 🐞 bug Crashes, Something isn't working, .. Feature:SearchProvider labels Dec 2, 2019
@mcarare mcarare added this to Polish Bugs to Triage in Feature Polish via automation Dec 3, 2019
@sv-ohorvath
Copy link
Contributor

@ekager I saw something related but I'm not sure it matches your description:
changing from EN to RU, for e.g, I'm left only with Twitter (all the others are removed)... I should get Google and Yandex at the very least.
Changed to DE: I only got Bing, DuckDuckGo and Twitter.
Is that a different issue or is it the same?

@sv-ohorvath sv-ohorvath added the S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill label Dec 6, 2019
@mcarare
Copy link
Contributor

mcarare commented Dec 6, 2019

related issue: #6981

@mcarare mcarare moved this from Polish Bugs to Triage to Prioritized Backlog in Feature Polish Dec 10, 2019
@kglazko
Copy link
Contributor

kglazko commented Dec 13, 2019 •
edited

Investigated this a bit deeper: it appears that on the emulator, changing the language will change the locale/search engines after a restart of the application (after which you will see missing providers in #6981). Verifying that this isn't an intended behavior @liuche

@kglazko kglazko self-assigned this Dec 13, 2019
@mcarare mcarare moved this from Prioritized Backlog to In progress in Feature Polish Dec 16, 2019
@boek boek added the P2 Upcoming release label Dec 27, 2019
@kglazko kglazko removed their assignment Feb 11, 2020
@kglazko
Copy link
Contributor

kglazko commented Feb 11, 2020

Unassigning myself because there are other priorities in polish to work on now.

@mcarare mcarare moved this from In progress to Prioritized Backlog in Feature Polish Feb 12, 2020
@boek boek self-assigned this Feb 18, 2020
boek added a commit to boek/fenix that referenced this issue Feb 19, 2020
@boek
For mozilla-mobile#6981 mozilla-mobile#6907 - Properly reloads search…
c6f0221 
… engines when locale changes
@boek boek moved this from Prioritized Backlog to In progress in Feature Polish Feb 19, 2020
boek added a commit to boek/fenix that referenced this issue Feb 19, 2020
@boek
For mozilla-mobile#6981 mozilla-mobile#6907 - Properly reloads search…
b5bf84f 
… engines when locale changes
boek added a commit that referenced this issue Feb 19, 2020
@boek
For #6981 #6907 - Properly reloads search engines when locale changes
1ba64f9
@ekager ekager added the eng:qa:needed QA Needed label Feb 26, 2020
@project-bot project-bot bot moved this from In progress to Ready for QA in Feature Polish Feb 26, 2020
@ekager ekager removed the eng:qa:needed QA Needed label Feb 26, 2020
@ekager
Copy link
Contributor Author

ekager commented Feb 26, 2020

Closing as dupe of #6981

@ekager ekager closed this as completed Feb 26, 2020
Feature Polish automation moved this from Ready for QA to Done Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@boek boek

Labels
🐞 bug Crashes, Something isn't working, .. Feature:SearchProvider P2 Upcoming release S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill
Projects
No open projects
Feature Polish
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@boek @kglazko @sv-ohorvath @ekager @mcarare