Before Release: add Release-only locales to list #7104
Comments
liuche
added
feature request 🌟
liuche
added
the
🙅 waiting
|
@vesta0 will we want to filter out partially-translated locales after Beta Migration, or do we want to keep all the translated strings? Filtering will mean that users in that locale will see English-only, rather than a (low percentage) partial translation. We'll have to contact @Pike soon if we want to get that list. |
|
@liuche do we how what percentage of strings have been translated? How far are we from Fennec parity in term of localization? |
|
Here's the current progress on Pontoon (and I think Fenix is the main Android project): What do you think, @Pike (or Jeff Beatty but I don't know his github) - do we know enough about the localization languages progress compared to Fennec to make this release list? |
|
I'll punt this to @gueroJeff |
This is the link I've been using: https://pontoon.mozilla.org/projects/android-l10n/tags/fenix/
We're not going to reach parity, just by virtue of some locales shipping on Fennec chose not to participate in localizing Fenix. The metric we're using is average completion across all locales. Fennec was at 90% across all locales, Fenix is currently at 75% average. To answer the earlier question, all products ship partial localizations. That's part of the risk that accompanies community localization. Fenix should follow that practice too. |
vesta0
moved this from Prioritized Feature Backlog
to Prioritized Eng Backlog
in Fenix Sprint Kanban
|
@gueroJeff will review the locales and decide on what the cutoff for inclusion with the Release build. Once he gives us the criteria (and the locales?) we'll be able to update the script to include the release locales. |
|
I'm going to set the cutoff at 70% complete. There's some automation the Bedrock team implemented to determine how complete a localization is and then automatically push it to prod when it reaches a certain threshold. Similar automation here would be preferred, but if we're unable to get that for the launch, I can produce a manual list at l10n freeze. |
liuche
added
🙅 waiting
|
We'll need to uplift the new localizations up until July 18, which will be after code freeze (which is okay because it's new strings only). After we know the localization rate, we'll be able to determine the locales to include/filter. However, right now, we can still figure out how to make this work for the current set of locales, and just update the specific set of locales once we know their completion rates. |
liuche
added
🙅 waiting
liuche
added
79ReleaseBlocker
and removed
🙅 waiting
|
I downloaded an apk from here since it looks like we run a script in taskcluster to remove locales that aren't in the locale list. Then I manually went through the languages and checked off the locales I saw in the l10n config. Some locales were missing, maybe related to #12613? The missing locales are |
|
I currently don't see either Uzbek (uz) nor Kannada (kn) on the latest Nightly. They both have partial localizations, so this is maybe also related to #12613? |
|
We don't have the strings for Uzbek or Kannada in the app yet. Looks like they're just missing due to lag in getting the translations pulled in. The TC script to strip locales works on my machine so it looks like the first part of this issue is verified. |
…zilla-mobile#12740)" This reverts commit 4fea8b3.
…zilla-mobile#12740)" This reverts commit 4fea8b3.
…zilla-mobile#12740)" This reverts commit 4fea8b3.
|
This will be ready for QA once we cut the Release Candidate for the Firefox Production Migration. We will want to verify that in the language picker, only the approved 70%+ locales are included (see delphine's comment above for that list). |
|
@liuche started testing on 79.0.0 AC 48.0.8 RC2 and a couple of locales are missing, here are some of them: an, bn, bs, cs, dsb, el, eo, et, fa, ff, gd, gn, he, hsb, hy-Am, id, is, kk, kn, lij, lt, ml, mr, my. On what RC should we test this? |
|
So I've tested on this 79 build (that I got from https://firefox-ci-tc.services.mozilla.com/tasks/index/mobile.v2.fenix.fennec-production.2020.07.24.revision), and I'm seeing a few locales missing (not all the ones mentioned above): |
|
I see dsb and hsb as Lower Sorbian and Upper Sorbian. bn is Bangla I think? I don't see he or id in that apk |
|
@person808 any ideas on what might be happening here? are these getting filtered out by accident, or are they not being included/imported at all? |
|
Not sure. When I run the filtering script locally on the Edit: Wait the |
|
Not that I know a lot about Android, but
|
|
Those are mapped in https://github.com/Pike/compare-locales/blob/e3eab8131efa2d2a2c7c81827b8ff9d7ac2f2d9a/compare_locales/paths/matcher.py#L13-L19 between project config and disk paths. If either |
|
Testing results: Note:
|
|
There are also inconsistencies in that list. Several display names are the locale code, not the language name. Several are not in English (e.g., "Polski") and the two Chinese should display as Simplified Chinese (zh-CN) and Traditional Chinese (zh-TW). |
|
We don't have control over the natural names, those are coming from Android (and I think that's a feature). For Hebrew and Indonesian, we should translate the codes when reading the release locales, probably. I'd not make the config list be different. Filed #13066 on that. |
|
Ah I see. Looks like l10n.toml contains "he" and "id" instead of "iw" and "in" so the folders are being deleted. Will file PRs to update the script so its aware of the mappings in the release branch and master |
|
I'll close this since the filtering appears to work except for Hebrew and Indonesian. We can verify that they are present when we QA #13066 |
Why/User Benefit/User Problem
Currently, we will bundle the same locales in Nightly and Preview, regardless of what status of translation they are in.
However, before we make our main release, we need to make sure only release-approved locales are included. They should be on Nightly and Beta, but not Production builds.
Acceptance Criteria (how do I know when I’m done?)
Before July 18:
On July 20:
L10N strings uplift discussion
L10N locale doc┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: