Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Settings] Turn on Sync card outline doesn't show up in Dark theme #7282

Closed
AmyYLee opened this issue Dec 18, 2019 · 0 comments · Fixed by #7284
Closed

[Settings] Turn on Sync card outline doesn't show up in Dark theme #7282

AmyYLee opened this issue Dec 18, 2019 · 0 comments · Fixed by #7284
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Settings Feature:Themes Dark mode, light mode, private browsing mode help wanted Help wanted from a contributor. More complex than good first issue. implementation review P2 Upcoming release
Projects
Feature Polish

Comments

@AmyYLee
Copy link
Collaborator

AmyYLee commented Dec 18, 2019 •
edited by data-sync-user
Loading

Steps to reproduce:

  1. Set Fenix to dark theme (Settings -> Theme)
  2. Go back to Settings list

Expected:
Can see the outline of the "Sign into Sync" card outline

Actual: Can't see the card outline

Spec for correct colouring:
https://share.goabstract.com/802db82a-ab34-4baf-822d-7f9a4e0125b9?mode=design&sha=55df3f5a5598c442a978d0268b7574deb0c7ca7d

Screen Shot 2019-12-18 at 4 56 36 PM

┆Issue is synchronized with this Jira Task
@AmyYLee AmyYLee added 🐞 bug Crashes, Something isn't working, .. Feature:Themes Dark mode, light mode, private browsing mode implementation review Feature:Settings labels Dec 18, 2019
@AmyYLee AmyYLee added this to UX Implementation Review in Feature Polish Dec 18, 2019
@joshvocal joshvocal mentioned this issue Dec 19, 2019
Merged
4 tasks
@boek boek added help wanted Help wanted from a contributor. More complex than good first issue. P2 Upcoming release and removed needs:group-triage labels Dec 31, 2019
Feature Polish automation moved this from UX Implementation Review to Done Jan 8, 2020
gabrielluong pushed a commit that referenced this issue Jan 8, 2020
@joshvocal @gabrielluong
For #7282 - Add more visibility to Turn On Sync card (#7284)
31da69a 
* Change background of card to make elevation more visible
* Change icon white fill to become transparent
@liuche liuche mentioned this issue Jan 22, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Settings Feature:Themes Dark mode, light mode, private browsing mode help wanted Help wanted from a contributor. More complex than good first issue. implementation review P2 Upcoming release
Projects
No open projects
Feature Polish
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more visibility to Turn On Sync card ↩️ joshvocal/fenix
2 participants
@boek @AmyYLee