Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Failure to build with autopublish.android-components.dir nested, relative directories on Linux #7366

Closed
hawkinsw opened this issue Dec 26, 2019 · 1 comment
Closed

[Bug] Failure to build with autopublish.android-components.dir nested, relative directories on Linux #7366

hawkinsw opened this issue Dec 26, 2019 · 1 comment
Assignees
@hawkinsw
Labels
🐞 bug Crashes, Something isn't working, .. eng:release Release Engineering

Comments

@hawkinsw
Copy link
Contributor

hawkinsw commented Dec 26, 2019 •
edited by data-sync-user

Steps to reproduce

On Linux, set autoPublish.android-components.dir to use a relative directory that is not immediately "adjacent" to the cwd. For example

autoPublish.android-components.dir=../ac/android-components/

will not work, but

autoPublish.android-components.dir=../android-components/

does.

Patch incoming.

Expected behavior

Both should compile.

Actual behavior

gradle compilation fails in runCmd on settings.gradle line 7.

Device information

N/A

┆Issue is synchronized with this Jira Task
@hawkinsw hawkinsw added 🐞 bug Crashes, Something isn't working, .. eng:release Release Engineering labels Dec 26, 2019
@hawkinsw hawkinsw self-assigned this Dec 26, 2019
@boek boek added the P1 Current sprint label Dec 27, 2019
grigoryk pushed a commit that referenced this issue Jan 8, 2020
@hawkinsw @grigoryk
Fix Issue #7366: Reference local android-components gradlew correctly
98cc869 
In `settings.gradle` when Fenix determines whether there is an
overriding local android-components it calls `gradlew` from the
`autoPublish.android-components.dir` directory. It sets the current
working directory (cwd) to `autoPublish.android-components.dir` and then
invokes `<autoPublish.android-components.dir>/gradlew`. The proper
behavior is to invoke `./gradlew` because the cwd is already set properly.
@liuche liuche mentioned this issue Jan 22, 2020
Closed
32 tasks
@boek boek removed the P1 Current sprint label Apr 20, 2020
@Rob--W
Copy link

Rob--W commented Jun 15, 2020

PR #7367 has been merged. Is there any reason for this bug still being open?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hawkinsw hawkinsw

Labels
🐞 bug Crashes, Something isn't working, .. eng:release Release Engineering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kbrosnan @boek @Rob--W @hawkinsw