This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Improve inflate performance in HomeFragment.onCreateView() #7423

Closed

emalysz opened this issue Dec 30, 2019 · 2 comments

Assignees

Labels

Milestone

Contributor

emalysz commented Dec 30, 2019 •

edited by data-sync-user

Why/User Benefit/User Problem

It is slow to create the HomeFragment (#4665).
A significant amount of time (952.658 ms) is spent in HomeFragment's onCreateView(). Of this, 56.38% is spent in inflate.

What/Requirements

Acceptance Criteria (how do I know when I’m done?)

-The time it takes to inflate the home fragment has been reduced.

┆Issue is synchronized with this Jira Task

emalysz added the performance label

emalysz added this to Needs prioritization in Performance, front-end roadmap via automation

hawkinsw mentioned this issue

File low-hanging fruit in Home Fragment creation #4665

Closed

Contributor Author

emalysz commented Dec 31, 2019

One potential solution could be using an AsyncLayoutInflater. See Marc's implementation of an AsyncLayoutInflater here for reference: https://github.com/MarcLeclair/fenix/commits/issue_6274_asynclayoutinflater_for_toolbar

boek added the P2 label

mcomella mentioned this issue

File low hanging fruit for view-related cold startup perf improvements #7446

Closed

emalysz assigned emalysz and unassigned emalysz

mcomella moved this from Needs prioritization to Backlog (prioritized) in Performance, front-end roadmap

mcomella added a commit to mcomella/fenix that referenced this issue


          For mozilla-mobile#7423: remove unnecessary wordmark_spacer view.

d792c19

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

mcomella added a commit to mcomella/fenix that referenced this issue


          For mozilla-mobile#7423: remove unnecessary CoordinatorLayout in frag…

52d4338

…ment_home.

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

mcomella added a commit to mcomella/fenix that referenced this issue


          Issue mozilla-mobile#7423: remove redundant bottom_bar ConstraintLayout.

f5e0967

mcomella added a commit to mcomella/fenix that referenced this issue


          For mozilla-mobile#7423: remove unnecessary wordmark_spacer view.

d8613df

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

mcomella added a commit to mcomella/fenix that referenced this issue


          For mozilla-mobile#7423: remove unnecessary CoordinatorLayout in frag…

…ment_home.

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

mcomella added a commit that referenced this issue


          For #7423: remove unnecessary wordmark_spacer view.

a1cbbba

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

mcomella added a commit that referenced this issue


          For #7423: remove unnecessary CoordinatorLayout in fragment_home.

ffb2e72

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

cadeyrn mentioned this issue

[Bug] (regression) "tab closed" snackbar no longer disappears #7799

Closed

emalysz pushed a commit to emalysz/fenix that referenced this issue


          For mozilla-mobile#7423: remove unnecessary wordmark_spacer view.

ce4d15c

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

emalysz pushed a commit to emalysz/fenix that referenced this issue


          For mozilla-mobile#7423: remove unnecessary CoordinatorLayout in frag…

96deff9

…ment_home.

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

emalysz pushed a commit to emalysz/fenix that referenced this issue


          Issue mozilla-mobile#7423: remove redundant bottom_bar ConstraintLayout.

cc5d450

emalysz added a commit to emalysz/fenix that referenced this issue


          Issue mozilla-mobile#7423: ensure transition works correctly

d445f0a

emalysz pushed a commit to emalysz/fenix that referenced this issue


          For mozilla-mobile#7423: remove unnecessary wordmark_spacer view.

199701e

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

emalysz pushed a commit to emalysz/fenix that referenced this issue


          For mozilla-mobile#7423: remove unnecessary CoordinatorLayout in frag…

89fde12

…ment_home.

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

emalysz pushed a commit to emalysz/fenix that referenced this issue


          Issue mozilla-mobile#7423: remove redundant bottom_bar ConstraintLayout.

f819e9a

emalysz pushed a commit that referenced this issue


          For #7423: remove unnecessary wordmark_spacer view.

e1c4808

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

emalysz pushed a commit that referenced this issue


          For #7423: remove unnecessary CoordinatorLayout in fragment_home.

c729e9a

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

emalysz pushed a commit that referenced this issue


          Issue #7423: remove redundant bottom_bar ConstraintLayout.

bf92519

liuche mentioned this issue

Releng for 3.2 #7845

Closed

32 tasks

liuche added this to the v3.2 milestone

emalysz pushed a commit that referenced this issue


          For #7423: remove unnecessary wordmark_spacer view.

d7fd8e7

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

emalysz pushed a commit that referenced this issue


          For #7423: remove unnecessary CoordinatorLayout in fragment_home.

91a557d

Co-authored-by: Emma Malysz <emalysz@mozilla.com>

emalysz pushed a commit that referenced this issue


          Issue #7423: remove redundant bottom_bar ConstraintLayout.

847056b

emalysz self-assigned this

mcomella removed this from Backlog (prioritized) in Performance, front-end roadmap

Contributor

mcomella commented Mar 2, 2020

We've done some work in a related view/inflation performance issue and this is too general to remain actionable: closing.

mcomella closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.