Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Permanently blocked by the system, camera and mic permissions don't appear in the site info panel #7566

Closed
sv-ohorvath opened this issue Jan 9, 2020 · 9 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:SitePermissions S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Jan 9, 2020

Steps to reproduce

Make sure to clear app data and have the default permissions settings.

  1. Go to permission.site, switch to https
  2. Tap the camera or mic buttons.
  3. Deny access on the first system permissions prompt.
  4. Tap the cam or mic buttons again and tap "Deny and Don't ask again" on the system permissions prompt.
  5. Tap the lock icon and check the site info panel.

Expected behavior

The permissions appear as Blocked by Android and the user needs to go to App info and turn on the permissions.
see also:
#7566 (comment)

Actual behavior

The 2 permissions permanently blocked by the system don't show up in the panel. The ones allowed/blocked by the app, do appear.
Note: if the system permissions are allowed first and then blocked in the App info>Permissions, they will appear correctly in the app.

Device information

  • Android device: Pixel 3
  • Fenix version: RC 3.0.2

┆Issue is synchronized with this Jira Task

@sv-ohorvath sv-ohorvath added 🐞 bug Crashes, Something isn't working, .. Feature:SitePermissions S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Jan 9, 2020
@vesta0
Copy link
Collaborator

vesta0 commented Jan 16, 2020

@Amejia481 will take a closer look and comment.

@Amejia481
Copy link
Contributor

This may be bit tricky as we are not storing non final state related to site permissions (nothing that doesn't have checkbox "Remember decision for this site"). For this reason, this info is not showing up in the panel the same can be seem with site permissions on private sessions.

This requires some significant effort from the ac team as this could change the way that we handle site permissions.

@Amejia481 Amejia481 self-assigned this Mar 9, 2020
@jonalmeida jonalmeida added this to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Mar 9, 2020
@Amejia481 Amejia481 moved this from ⏳ Sprint Backlog to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Apr 2, 2020
@Amejia481
Copy link
Contributor

@sv-ohorvath I was taking a look to what Fennec does for non final state the permissions are not getting shown in the site info panel neither.

@sv-ohorvath
Copy link
Contributor Author

sv-ohorvath commented Apr 3, 2020

@Amejia481 yes, that is true, they do work the same on Fennec.
Just a note that I was referring to camera and mic, which first show a system permission dialog, on which you can block the app's permissions (as opposed to location which first shows the in-app dialog and the system dialog only after)
I denied the cam & mic's permissions from the system dialog and set them to don't ask again. I was expecting to see a "Blocked by Android" status in the site info panel.
They only appear as Blocked by Android if the change is made AFTER you make a selection for the in-app dialogs.
Comparing to the location permission in Fennec, they behave the same. Only that the camera and mic permissions dialogs in Fennec don't have the "Don't ask again" option, so they never appear in the site settings panel.
Thanks. Do you think we can close this?

@Amejia481
Copy link
Contributor

Just a note that I was referring to camera and mic, which first show a system permission dialog, on which you can block the app's permissions (as opposed to location which first shows the in-app dialog and the system dialog only after)

I used the location permission as the only one on Fennec that has a checkbox in the dialog. Other permissions are always temporarily granted/allowed.

I denied the cam & mic's permissions from the system dialog and set them to don't ask again. I was expecting to see a "Blocked by Android" status in the site info panel.
They only appear as Blocked by Android if the change is made AFTER you make a selection for the in-app dialogs.

@sv-ohorvath this is good point, thanks for bring this up. Unfortunately this is also an issue present on Fennec, I believe we haven't covered this user path before. I think we should close this issue and open a new one for handling "the system permission dialog when the user clicks Deny & don't ask again", this has a completely different user flow, for example:

When the system permission dialog is requested for the first time, it only shows the Allow and Deny buttons, but if the Deny button is clicked, and we request the permission again, now the system permission dialog shows the Allow, Deny and Deny & don't ask again buttons, then if the Deny & don't ask again button is clicked, we can't show the system dialog again, this permission is always going to get auto-rejected by Android, the only way to access it is to take the user to "App Info" and there the user have to select the permission and allow it there otherwise it will be always denied .

@sv-ohorvath sv-ohorvath changed the title [Bug] Blocked camera and mic permissions don't appear in the site info panel [Bug] Permanently blocked by the system, camera and mic permissions don't appear in the site info panel Apr 6, 2020
@sv-ohorvath
Copy link
Contributor Author

@Amejia481 This is the case that it was meant to be covered in this ticket but I have to admit it was described lazily. I've modified the title and description to better match the issue. Sorry for that, I hope it makes more sense now.

@Amejia481
Copy link
Contributor

@Amejia481 This is the case that it was meant to be covered in this ticket but I have to admit it was described lazily. I've modified the title and description to better match the issue. Sorry for that, I hope it makes more sense now.

👍

Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 7, 2020
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 7, 2020
@Amejia481 Amejia481 moved this from 🏃‍♀️ In Progress to 🚷 Blocked in A-C: Android Components Sprint Planning Apr 9, 2020
@Amejia481 Amejia481 moved this from 🚷 Blocked to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Apr 13, 2020
@Amejia481 Amejia481 linked a pull request Apr 13, 2020 that will close this issue
4 tasks
@Amejia481 Amejia481 moved this from 🏃‍♀️ In Progress to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Apr 13, 2020
@Amejia481 Amejia481 moved this from ⏳ Sprint Backlog to 🚷 Blocked in A-C: Android Components Sprint Planning Apr 13, 2020
@Amejia481 Amejia481 moved this from 🚷 Blocked to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Apr 21, 2020
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 21, 2020
Amejia481 added a commit to Amejia481/fenix that referenced this issue Apr 22, 2020
@Amejia481 Amejia481 added the eng:qa:needed QA Needed label Apr 22, 2020
@Amejia481
Copy link
Contributor

This should be fixed in master, @sv-ohorvath would you mind taking a look ? :)

@sv-ohorvath
Copy link
Contributor Author

Verified as fixed on Nightly 4/23.
Devices: Pixel 4 (Android 10), HTC Desire (Android 6.0.1)

A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Apr 23, 2020
@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 23, 2020
@liuche liuche mentioned this issue Apr 28, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:SitePermissions S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
No open projects
Development

No branches or pull requests

3 participants