Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Back button should animate to the left before search screen disappears #7698

Closed
sblatz opened this issue Jan 14, 2020 · 2 comments
Closed

[Bug] Back button should animate to the left before search screen disappears #7698

sblatz opened this issue Jan 14, 2020 · 2 comments
Assignees
@sblatz
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search

Comments

@sblatz
Copy link
Contributor

sblatz commented Jan 14, 2020 •
edited by data-sync-user

Steps to reproduce

  1. Open the search screen
  2. Press back

Expected behavior

  1. The back button animates to the left (off of the screen) while the rest of the screen transitions

Actual behavior

  1. The back button stays in place while the rest of the screen transitions and then flickers out.

Device information

  • Android device: Galaxy S9 Android 9
  • Fenix version: 1/14/20 nightly

┆Issue is synchronized with this Jira Task
@sblatz sblatz added 🐞 bug Crashes, Something isn't working, .. Feature:Search labels Jan 14, 2020
@sblatz sblatz self-assigned this Jan 14, 2020
@sblatz
Copy link
Contributor Author

sblatz commented Jan 21, 2020

Updated animation:

back_button_animation

sblatz added a commit to sblatz/fenix that referenced this issue Jan 21, 2020
@sblatz
For mozilla-mobile#7698: Adds search back button animation
13c64da
sblatz added a commit to sblatz/fenix that referenced this issue Jan 21, 2020
@sblatz
For mozilla-mobile#7698: Adds search back button animation
d1fa838
sblatz added a commit to sblatz/fenix that referenced this issue Jan 21, 2020
@sblatz
For mozilla-mobile#7698: Adds search back button animation
1bf9958
sblatz added a commit to sblatz/fenix that referenced this issue Jan 22, 2020
@sblatz
For mozilla-mobile#7698: Adds search back button animation
342cda4
sblatz added a commit that referenced this issue Jan 22, 2020
@sblatz
For #7698: Adds search back button animation (#7840)
20396f7 
* For #7698: Adds search back button animation

* Refactor for searchController
@sblatz sblatz added the eng:qa:needed QA Needed label Jan 22, 2020
@sv-sdeiac
Copy link

Verified as fixed using the latest version of Firefox Preview Nightly 1/28 #20280606.
Devices:

  • Nokia 6 (Android 7.1.1);
  • OnePlus 5T (Android 9).

@sv-sdeiac sv-sdeiac added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sblatz sblatz

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sblatz @sv-sdeiac