Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

MotionLayout home screen performance is very slow on cold startups #7700

Closed
colintheshots opened this issue Jan 14, 2020 · 2 comments
Closed

MotionLayout home screen performance is very slow on cold startups #7700

colintheshots opened this issue Jan 14, 2020 · 2 comments
Assignees
@MarcLeclair
Labels
P1 Current sprint performance Possible performance wins
Projects
Performance, front-end roadmap

Comments

@colintheshots
Copy link
Contributor

colintheshots commented Jan 14, 2020 •
edited by data-sync-user

It appears from Marc Leclair's recent SysTrace results that our home screen is loading significantly more slowly in part due to the use of MotionLayouts for hiding the Firefox Preview wordmark image and private browsing mode button. Given the very simple behavior currently being used, we can instead produce this animation using stock CoordinatorLayout behaviors instead. This should also reduce the depth of the layout hierarchy, which already had a CoordinatorLayout parent.

In addition, the bottom bar layout uses a nested ConstraintLayout that could trivially be converted to a LinearLayout or RelativeLayout for an additional speedup.

┆Issue is synchronized with this Jira Task
@colintheshots colintheshots added P1 Current sprint performance Possible performance wins labels Jan 14, 2020
@colintheshots colintheshots self-assigned this Jan 14, 2020
@colintheshots colintheshots added this to Needs prioritization in Performance, front-end roadmap via automation Jan 14, 2020
@colintheshots colintheshots moved this from Needs prioritization to In progress in Performance, front-end roadmap Jan 14, 2020
@mcomella mcomella moved this from In progress to Needs prioritization in Performance, front-end roadmap Jan 16, 2020
@mcomella mcomella moved this from Needs prioritization to Backlog (prioritized) in Performance, front-end roadmap Jan 21, 2020
@MarcLeclair MarcLeclair self-assigned this Jan 21, 2020
@mcomella mcomella moved this from Backlog (prioritized) to In progress in Performance, front-end roadmap Jan 22, 2020
@mcomella mcomella mentioned this issue Jan 22, 2020
Closed
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Jan 22, 2020
@MarcLeclair
mozilla-mobile#7700 fixed linting issues
54002df
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Jan 22, 2020
@MarcLeclair
mozilla-mobile#7700 fixed linting issues
9069c9c
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Jan 22, 2020
@MarcLeclair
mozilla-mobile#7700 did an oopsie and deleted closing tag
4dfbcb4
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Jan 24, 2020
@MarcLeclair
mozilla-mobile#7700 fixed the home_component name and removed pointle…
a9ab817 
…ss file
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Jan 24, 2020
@MarcLeclair
mozilla-mobile#7700 detekt fix
7af865c
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Jan 24, 2020
@MarcLeclair
mozilla-mobile#7700 fixed layout to match the current one, that means…
a933f04 
… removing linear layout. Also added context to setuphomemenu
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Jan 24, 2020
@MarcLeclair
mozilla-mobile#7700 added comments, fixed names
e374b68
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Jan 24, 2020
@MarcLeclair
mozilla-mobile#7700 added bit more space at the bottom margin of the …
901d8c0 
…recycler view to match MotionLayout view from before
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Jan 29, 2020
@MarcLeclair
mozilla-mobile#7700 fixed bug where returning to a page didn't return…
7d523ca 
… to previous scroll position
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Jan 29, 2020
@MarcLeclair
mozilla-mobile#7700 fixed linting issues
3f0463c
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Jan 29, 2020
@MarcLeclair
mozilla-mobile#7700 fixed linting issues
6ae274c
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Jan 29, 2020
@MarcLeclair
mozilla-mobile#7700 fixed linting issues
951b0ad
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Jan 31, 2020
@MarcLeclair
mozilla-mobile#7700 fixed +1 that I added for some odd reason
1eec35d
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Feb 2, 2020
@MarcLeclair
mozilla-mobile#7700 fixed up the offSet to be clearer and be more con…
355ff18 
…cise in separating logic from high level functions + clean up
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Feb 2, 2020
@MarcLeclair
mozilla-mobile#7700 linting fix
16fcbd5
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Feb 4, 2020
@MarcLeclair
mozilla-mobile#7700 squash commit and fixing toolbar to switxh to top…
b498fdd 
… with coordinatorlayout
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Feb 4, 2020
@MarcLeclair
mozilla-mobile#7700 fixed scrolling, parallax action to match both im…
22a34fe 
…ages and some code clean up
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Feb 4, 2020
@MarcLeclair
mozilla-mobile#7700 fixed linting issues
e3b68c4
@MarcLeclair MarcLeclair mentioned this issue Feb 5, 2020
Closed
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Feb 5, 2020
@MarcLeclair
mozilla-mobile#7700 squash commit and fixing toolbar to switxh to top…
15478f3 
… with coordinatorlayout
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Feb 5, 2020
@MarcLeclair
mozilla-mobile#7700 fixed scrolling, parallax action to match both im…
36b98c6 
…ages and some code clean up
MarcLeclair added a commit to MarcLeclair/fenix that referenced this issue Feb 5, 2020
@MarcLeclair
mozilla-mobile#7700 fixed linting issues
f801a32
boek pushed a commit that referenced this issue Feb 6, 2020
@MarcLeclair @boek
#7700 squash commit and fixing toolbar to switxh to top with coordina…
7200759 
…torlayout
boek pushed a commit that referenced this issue Feb 6, 2020
@MarcLeclair @boek
#7700 fixed scrolling, parallax action to match both images and some …
92b3820 
…code clean up
boek pushed a commit that referenced this issue Feb 6, 2020
@MarcLeclair @boek
#7700 fixed linting issues
9fc5a1b
@mcomella
Copy link
Contributor

mcomella commented Feb 6, 2020

@MarcLeclair The associated PR was merged: please don't forget to update the bug status!

@MarcLeclair MarcLeclair moved this from In progress to Done in Performance, front-end roadmap Feb 7, 2020
@MarcLeclair
Copy link
Contributor

closed with #8085

@sblatz sblatz mentioned this issue Apr 15, 2020
Closed
@Mugurell Mugurell mentioned this issue Mar 1, 2023
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MarcLeclair MarcLeclair

Labels
P1 Current sprint performance Possible performance wins
Projects
Performance, front-end roadmap
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colintheshots @mcomella @MarcLeclair