Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] [a11y] Consider making the "Close tab" and "Restore tab" buttons larger (about:crashcontent) #7753

Closed
lobontiumira opened this issue Jan 16, 2020 · 4 comments
Closed

[Bug] [a11y] Consider making the "Close tab" and "Restore tab" buttons larger (about:crashcontent) #7753

lobontiumira opened this issue Jan 16, 2020 · 4 comments
Assignees
@mcarare
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:ErrorMessages P2 Upcoming release S3 Blocks non-critical functionality and a work around exists

Comments

@lobontiumira
Copy link

lobontiumira commented Jan 16, 2020 •
edited by data-sync-user

Prerequisite

Make sure you have Accessibility Scanner installed and turned on.

Steps to reproduce

  1. Launch Fenix, open a website.
  2. In the same tab, go to about:crashcontent.
  3. Scan the page using Accessibility Scanner.

Expected behavior

No major discrepancies are reported.

Actual behavior

The "Close tab" and "Restore tab" buttons are suggested to be increased from 36dp to 48dp or larger.

Device information

  • Android device: Huawei Honor 8 (Android 7), Samsung Galaxy Tab S3 (Android 8)
  • Fenix version: 01/16 Nightly build

Screenshot_20200116-110216_Accessibility Scanner

┆Issue is synchronized with this Jira Task
@lobontiumira lobontiumira added 🐞 bug Crashes, Something isn't working, .. access Accessibility: Talkback, HW keyboard/mouse, braile display etc. S3 Blocks non-critical functionality and a work around exists labels Jan 16, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 16, 2020
@sblatz sblatz self-assigned this Jan 29, 2020
@sblatz
Copy link
Contributor

sblatz commented Jan 29, 2020

This is something I'm already planning to fix in my error page updates. I'll confirm that I make these large enough 😄

@sblatz sblatz added P5 Never, but will accept a patch Feature:ErrorMessages and removed needs:triage Issue needs triage labels Jan 29, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Feb 7, 2020
@sblatz
For mozilla-mobile#7753: Increases touch target of crash page
3207229
sblatz added a commit to sblatz/fenix that referenced this issue Feb 7, 2020
@sblatz
For mozilla-mobile#7753: Increases touch target of crash page
7844e66
sblatz added a commit to sblatz/fenix that referenced this issue Feb 10, 2020
@sblatz
For mozilla-mobile#7753: Increases touch target of crash page
a37c5fe
boek pushed a commit that referenced this issue Feb 10, 2020
@sblatz @boek
For #7753: Increases touch target of crash page
453231b
@sblatz sblatz added the eng:qa:needed QA Needed label Feb 10, 2020
@lobontiumira
Copy link
Author

This is not fixed yet on the latest Nightly from 2/11. Verified with Samsung Galaxy Tab S3 (Android 8), and OnePlus 5T (Android 9). I'll remove the qa:needed label for now.

Screenshot_20200211-112213

@lobontiumira lobontiumira removed the eng:qa:needed QA Needed label Feb 11, 2020
@Diana-Rus
Copy link

Hi, this outcome is still present for "Close tab" and "Restore tab" buttons on Nightly 04/07 (Build #20980610) with Samsung Galaxy S9 (Android 8)

@vesta0 vesta0 removed the P5 Never, but will accept a patch label Apr 8, 2020
@sblatz sblatz removed their assignment Apr 13, 2020
@asadotzler asadotzler added the P2 Upcoming release label May 7, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Jun 4, 2020
@mcarare
For mozilla-mobile#7752, mozilla-mobile#7753: Adjust touch targets fo…
b573c3a 
…r elements in crash reporter.
@mcarare mcarare self-assigned this Jun 4, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Jun 5, 2020
@mcarare
For mozilla-mobile#7752, mozilla-mobile#7753: Adjust touch targets fo…
eaa0b9f 
…r elements in crash reporter.
mcarare added a commit to mcarare/fenix that referenced this issue Jun 5, 2020
@mcarare
For mozilla-mobile#7752, mozilla-mobile#7753: Adjust touch targets fo…
9bbf790 
…r elements in crash reporter.
mcarare added a commit that referenced this issue Jun 5, 2020
@mcarare
For #7752, #7753: Adjust touch targets for elements in crash reporter.
741fa79
@mcarare mcarare added the eng:qa:needed QA Needed label Jun 5, 2020
@sflorean
Copy link
Contributor

sflorean commented Jun 9, 2020

Verified as fixed on Nightly 6/9 with LG G7 FIT (Android 8) and Google Pixel (Android 10). No suggestions are made for the buttons "Close tab" and "restore tab".

@sflorean sflorean closed this as completed Jun 9, 2020
@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 9, 2020
@liuche liuche mentioned this issue Jun 10, 2020
Closed
29 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:ErrorMessages P2 Upcoming release S3 Blocks non-critical functionality and a work around exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@asadotzler @sblatz @lobontiumira @vesta0 @mcarare @Diana-Rus @sflorean