Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] The floating pop-up is not positioned correctly when scrolling #8080

Closed
abodea opened this issue Feb 4, 2020 · 3 comments
Closed

[Bug] The floating pop-up is not positioned correctly when scrolling #8080

abodea opened this issue Feb 4, 2020 · 3 comments
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Shortcuts Top Sites/Topsites on the Firefox home page help wanted Help wanted from a contributor. More complex than good first issue. P3 Some future sprint S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
Hershey's 🍫

Comments

@abodea
Copy link
Member

abodea commented Feb 4, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Launch Fenix and reach the home screen.
  2. Add a website to Firefox home.
  3. Reach the Firefox home.
  4. Tap and hold on the recently added top site and scroll slowly

Expected behavior

When releasing the button, the floating pop-up should be displayed near the recently added top site.

Actual behavior

The floating pop-up remains in the same place.

Device information

  • Android device: Huawei 20 Mate(Android 8.1.1).
  • Fenix version: Latest Nightly from 2/4.

ezgif-5-5b3e218f61d0 (1)

┆Issue is synchronized with this Jira Task
@abodea abodea added 🐞 bug Crashes, Something isn't working, .. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist Feature:Shortcuts Top Sites/Topsites on the Firefox home page labels Feb 4, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 4, 2020
@mcarare mcarare added this to Polish Bugs to Triage in Feature Polish via automation Feb 5, 2020
@vesta0 vesta0 removed this from Polish Bugs to Triage in Feature Polish Mar 29, 2020
@vesta0 vesta0 added this to Homescreen in Polish Mar 29, 2020
@ekager ekager added eng:qa:needed QA Needed and removed needs:triage Issue needs triage labels Apr 17, 2020
@ekager
Copy link
Contributor

ekager commented Apr 17, 2020

Looks like these menus get dismissed now before scrolling but let's test

@AndiAJ
Copy link
Collaborator

AndiAJ commented Apr 22, 2020

Hi, still reproducible on the latest Nightly Build #21130610 from 4/22 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

►Video
20200422-092501

@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Apr 22, 2020
@vesta0 vesta0 added the P3 Some future sprint label Apr 28, 2020
@vesta0 vesta0 removed this from Homescreen in Polish Apr 28, 2020
@ekager ekager added eng:ready Ready for engineering help wanted Help wanted from a contributor. More complex than good first issue. labels Apr 28, 2020
@mcarare mcarare self-assigned this Jun 24, 2020
@mcarare mcarare added this to In Progress in Hershey's 🍫 Jun 24, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Jun 24, 2020
@mcarare
For mozilla-mobile#8080: Dismiss menu when swiping away from its anchor.
b50ab59
@mcarare mcarare added the E3 Estimation Point: average, 2 - 3 days label Jun 24, 2020
@codrut-topliceanu codrut-topliceanu moved this from In Progress to QA Review in Hershey's 🍫 Jun 24, 2020
@codrut-topliceanu codrut-topliceanu moved this from QA Review to In Dev Review in Hershey's 🍫 Jun 24, 2020
ekager pushed a commit to mcarare/fenix that referenced this issue Jun 25, 2020
@mcarare @ekager
For mozilla-mobile#8080: Dismiss menu when swiping away from its anchor.
40a0f84
ekager pushed a commit that referenced this issue Jun 25, 2020
@mcarare @ekager
For #8080: Dismiss menu when swiping away from its anchor.
a056e86
@ekager ekager added the eng:qa:needed QA Needed label Jun 25, 2020
@mcarare mcarare moved this from In Dev Review to QA Review in Hershey's 🍫 Jun 25, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 25, 2020

Hi, verified as fixed on the latest Nightly Build 200625 from 6/25 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200625-113959

@AndiAJ AndiAJ closed this as completed Jun 25, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 25, 2020
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
@mcarare mcarare moved this from QA Review to Done in Hershey's 🍫 Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Shortcuts Top Sites/Topsites on the Firefox home page help wanted Help wanted from a contributor. More complex than good first issue. P3 Some future sprint S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
No open projects
Hershey's 🍫
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ekager @vesta0 @abodea @mcarare @AndiAJ