Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] ETP options from onboarding screen can be selected when ETP is turned off #8523

Closed
abodea opened this issue Feb 19, 2020 · 1 comment
Closed

[Bug] ETP options from onboarding screen can be selected when ETP is turned off #8523

abodea opened this issue Feb 19, 2020 · 1 comment
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
Workflow

Comments

@abodea
Copy link
Member

abodea commented Feb 19, 2020 •
edited by data-sync-user

Prerequisites

Have a fresh install.

Steps to reproduce

  1. Launch Fenix.
  2. Go to the "Protect yourself" card;
  3. Turn ETP off.
  4. Tap on Standard or Strict.

Expected behavior

The options should not change until turning ETP back on.

Actual behavior

ETP options from the onboarding screen can be changed when ETP is turned off.

Device information

  • Android device: Google Pixel 3a XL(Android 10), Samsung Galaxy S10+ (Android 9), OnePlus 6T (Android 9), Samsung Galaxy S7 (Android 7), OnePlus A3(Android 6), Nexus 4, android 5.1.1.
  • Fenix version: Nightly build 2/19, Beta 4.0.0.

Notes

When changing the ETP option while it's off, it remains saved when checking the settings' ETP menu.
20200219-111205

┆Issue is synchronized with this Jira Task
@abodea abodea added 🐞 bug Crashes, Something isn't working, .. Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Feb 19, 2020
@mcarare mcarare self-assigned this Feb 19, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 19, 2020
@mcarare mcarare added this to App Navigation in Workflow Feb 19, 2020
@mcarare mcarare moved this from App Navigation to Doing in Workflow Feb 19, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 19, 2020
For mozilla-mobile#8523: Also disable radio buttons clickable area wh…
550fd9f 
…en ETP is off
@mcarare mcarare removed the needs:triage Issue needs triage label Feb 19, 2020
ekager pushed a commit that referenced this issue Feb 19, 2020
@ekager
For #8523: Also disable radio buttons clickable area when ETP is off
a5ac730
@ekager ekager added the eng:qa:needed QA Needed label Feb 19, 2020
@sv-sdeiac
Copy link

Verified as fixed using the latest version of Firefox Preview Nightly 2/24 #20550606.

Now the options are not selectable after disabling ETP from the onboarding screen. Also verified that the last change from the onboarding before the disable is saved and reflect also in the settings ETP menu.

Devices:

  • Motorola Moto G6 (Android 8);
  • Samsung Galaxy S8 (Android 9).

@sv-sdeiac sv-sdeiac added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Feb 24, 2020
@sblatz sblatz moved this from Doing to Done in Workflow Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
No open projects
Workflow
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ekager @sv-sdeiac @abodea @mcarare