Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Find in page and address bar remain in fullscreen #8541

Closed
kbrosnan opened this issue Feb 19, 2020 · 1 comment
Closed

[Bug] Find in page and address bar remain in fullscreen #8541

kbrosnan opened this issue Feb 19, 2020 · 1 comment
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:FindBar Feature:Media help wanted Help wanted from a contributor. More complex than good first issue. P3 Some future sprint
Projects
A-C: Media

Comments

@kbrosnan
Copy link
Contributor

kbrosnan commented Feb 19, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  • Go to Youtube
  • Open a video page e.g. Mushroom risotto
  • Open find in page search for mus
  • Tap play
  • Tap full screen

Expected behavior

  • No find bar covering the video

Actual behavior

  • Find bar covers the video
  • tapping the x in the find bar shows the address bar
    Screenshot_20200219-082556

Device information

  • Android device: Pixel 3 Android 10
  • Fenix version: 2/19 @ 6:06 AM

┆Issue is synchronized with this Jira Task
@kbrosnan kbrosnan added 🐞 bug Crashes, Something isn't working, .. Feature:Media needs:group-triage labels Feb 19, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 19, 2020
@boek boek added P3 Some future sprint Feature:FindBar eng:ready Ready for engineering good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue. and removed good first issue Good for newcomers needs:group-triage needs:triage Issue needs triage labels Mar 3, 2020
miDeb added a commit to miDeb/fenix that referenced this issue Mar 5, 2020
@miDeb
Closes mozilla-mobile#8541: Hide find bar when entering fullscreen
d8a4ada
miDeb added a commit to miDeb/fenix that referenced this issue Mar 6, 2020
@miDeb
Revert "Closes mozilla-mobile#8541: Hide find bar when entering fulls…
0eb3181 
…creen"

This reverts commit d8a4ada.
miDeb added a commit to miDeb/fenix that referenced this issue Mar 6, 2020
@miDeb
Closes mozilla-mobile#8541: Hide find bar when entering fullscreen
92e70b8
@miDeb miDeb mentioned this issue Mar 6, 2020
Closed
4 tasks
@st3fan st3fan added this to Fenix Media Issues in A-C: Media Mar 27, 2020
@ekager ekager moved this from Fenix Media Bugs to Eng Ready - Fenix Team in A-C: Media Apr 11, 2020
ekager pushed a commit to miDeb/fenix that referenced this issue Apr 21, 2020
@miDeb @ekager
Closes mozilla-mobile#8541: Hide find bar when entering fullscreen
1194891
@ekager ekager moved this from Fenix Eng-Ready Bug Backlog to In Progress in A-C: Media Apr 21, 2020
@ekager ekager closed this as completed in 1f8b7ff Apr 22, 2020
A-C: Media automation moved this from In Progress to Done Apr 22, 2020
@ekager ekager reopened this Apr 22, 2020
@ekager ekager added the eng:qa:needed QA Needed label Apr 22, 2020
@sflorean
Copy link
Contributor

Verified as fixed on Nightly build from 4/23. Devices: Nokia 6 (Android 7.1.1) and Samsung Galaxy Note 10 (Android 10).

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 23, 2020
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:FindBar Feature:Media help wanted Help wanted from a contributor. More complex than good first issue. P3 Some future sprint
Projects
No open projects
A-C: Media
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #8541: Close find bar when entering fullscreen miDeb/fenix
4 participants
@kbrosnan @boek @ekager @sflorean