Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Device name should not apper under "Choose what to sync" header in Account page #8592

Closed
sblatz opened this issue Feb 20, 2020 · 2 comments
Closed

[Bug] Device name should not apper under "Choose what to sync" header in Account page #8592

sblatz opened this issue Feb 20, 2020 · 2 comments
Assignees
@eliserichards
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Accounts implementation review P3 Some future sprint
Projects
4.2

Comments

@sblatz
Copy link
Contributor

sblatz commented Feb 20, 2020 •
edited by data-sync-user
Loading

Currently the device name appears under the "Choose what to sync" header in the account page, but is not really part of that section. It should appear above it.

image

┆Issue is synchronized with this Jira Task
@sblatz sblatz added 🐞 bug Crashes, Something isn't working, .. Feature:Accounts labels Feb 20, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 20, 2020
@eliserichards eliserichards self-assigned this Mar 12, 2020
@ekager
Copy link
Contributor

ekager commented Mar 12, 2020

As part of this ticket, we should make sure that the Device name field is still disabled while syncing (currently being done through the category IIRC)

@AmyYLee AmyYLee added the P3 Some future sprint label Mar 13, 2020
@eliserichards eliserichards added this to doing in 4.2 Mar 16, 2020
@eliserichards eliserichards moved this from doing to ready for review in 4.2 Mar 16, 2020
@eliserichards eliserichards removed the needs:triage Issue needs triage label Mar 16, 2020
eliserichards added a commit to eliserichards/fenix that referenced this issue Mar 19, 2020
@eliserichards
For mozilla-mobile#8592: Relocate device name in account preferences.…
8972f7b 
… Deactivate device name field while syncing.
eliserichards added a commit to eliserichards/fenix that referenced this issue Mar 19, 2020
@eliserichards
For mozilla-mobile#8592: Relocate device name in account preferences.…
61fe7d3 
… Deactivate device name field while syncing.
eliserichards added a commit that referenced this issue Mar 20, 2020
@eliserichards
For #8592: Relocate device name in account preferences. Deactivate de…
5d8a9bb 
…vice name field while syncing. (#9255)
@eliserichards eliserichards moved this from ready for review to ready for qa in 4.2 Mar 20, 2020
@eliserichards eliserichards added the eng:qa:needed QA Needed label Mar 20, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Mar 23, 2020

Hi, verified as fixed on the latest Nightly Build #20830607 from 3/23 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S6 (Android 7)
• OnePlus A3 (Android 6.0.1)

►Screenshot
rsz_1screenshot_20200323-091207

@AndiAJ AndiAJ closed this as completed Mar 23, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 23, 2020
@liuche liuche mentioned this issue Mar 24, 2020
Closed
32 tasks
@liuche liuche moved this from ready for qa to done in 4.2 Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eliserichards eliserichards

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Accounts implementation review P3 Some future sprint
Projects
No open projects
4.2
done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sblatz @AmyYLee @ekager @eliserichards @AndiAJ