Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[History] 3-dot menu should have more options #8651

Closed
AmyYLee opened this issue Feb 21, 2020 · 3 comments
Closed

[History] 3-dot menu should have more options #8651

AmyYLee opened this issue Feb 21, 2020 · 3 comments
Assignees
@Mugurell
Labels
eng:qa:verified QA Verified Feature:History implementation review P2 Upcoming release
Projects
4.2

Comments

@AmyYLee
Copy link
Collaborator

AmyYLee commented Feb 21, 2020 •
edited by data-sync-user
Loading

History can be shared by long pressing -> selecting share from the top. It should be available from the history 3-dot menu in the list item.

Current 3-dot menu:

  • Delete

Updated menu:

  • Copy
  • Share
  • Open in new tab
  • Open in private tab
  • Delete

CC' @topotropic

┆Issue is synchronized with this Jira Task
@topotropic topotropic mentioned this issue Feb 27, 2020
Closed
11 tasks
@topotropic
Copy link

cc @KaairaGupta

@Mugurell Mugurell self-assigned this Mar 13, 2020
@Mugurell Mugurell removed the needs:triage Issue needs triage label Mar 13, 2020
@AmyYLee AmyYLee added the P2 Upcoming release label Mar 13, 2020
@Mugurell Mugurell added this to doing in 4.2 Mar 18, 2020
@Mugurell Mugurell moved this from doing to ready for review in 4.2 Mar 19, 2020
@ekager ekager closed this as completed in a1cdd31 Mar 27, 2020
ekager pushed a commit that referenced this issue Mar 27, 2020
@Mugurell @ekager
For #8651 - Ensure FenixSnackbar has a proper root for inflating into
fc0260d 
FenixSnackbar, as the platform Snackbar can only be inflated in either a
`CoordinatorLayout` or a `FrameLayout`.
Ensure our HistoryFragment's layout uses one of these as it's root.
ekager pushed a commit that referenced this issue Mar 27, 2020
@Mugurell @ekager
For #8651 - Add HistoryInteractor/Controller unit/ui tests
9f3bbf1
@ekager ekager added the eng:qa:needed QA Needed label Mar 27, 2020
@ekager
Copy link
Contributor

ekager commented Mar 27, 2020

Reopening to verify

@ekager ekager reopened this Mar 27, 2020
@sv-sdeiac
Copy link

Verified as fixed using the latest version of Firefox Preview Nightly 3/29 #20891805.

Devices:

  • Google Pixel 3 (Android 10);
  • Samsung Galaxy Tab S6 (Android 9).

@sv-sdeiac sv-sdeiac added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 30, 2020
@liuche liuche moved this from ready for review to done in 4.2 Mar 30, 2020
@liuche liuche mentioned this issue Apr 13, 2020
Closed
32 tasks
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
eng:qa:verified QA Verified Feature:History implementation review P2 Upcoming release
Projects
No open projects
4.2
done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@topotropic @AmyYLee @Mugurell @ekager @sv-sdeiac