Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Support RTL for theme / toolbar position picker images in Onboarding #8693

Closed
Mugurell opened this issue Feb 24, 2020 · 7 comments
Closed

Support RTL for theme / toolbar position picker images in Onboarding #8693

Mugurell opened this issue Feb 24, 2020 · 7 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR
Projects

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Feb 24, 2020

This would provide a better RTL experience.
Initially reported in #8469, it was seen in #8673 that simply mirroring the existing imagery is not a solution.
For actually fixing this we need new images that would reflect the actual experience RTL users would have.

┆Issue is synchronized with this Jira Task

@Mugurell Mugurell added 🐞 bug Crashes, Something isn't working, .. needs:UX-feedback Needs UX Feedback needs:triage Issue needs triage labels Feb 24, 2020
@brampitoyo
Copy link

@Mugurell I’ve designed an RTL variant that’s ready for export, and @apbitner (who’s the owner of this feature) will be able to post the assets here.

@brampitoyo brampitoyo added the Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR label Mar 12, 2020
@brampitoyo
Copy link

@Mugurell RTL assets posted below. Thanks!

MDPI

onboarding_light_theme_rtl
onboarding_dark_theme_rtl

HDPI - 1.5x

onboarding_light_theme_rtl@1 5x
onboarding_dark_theme_rtl@1 5x

XHDPI - 2x

onboarding_light_theme_rtl@2x
onboarding_dark_theme_rtl@2x

XXHDPI - 3x

onboarding_light_theme_rtl@3x
onboarding_dark_theme_rtl@3x

XXXHDPI - 4x

onboarding_light_theme_rtl@4x
onboarding_dark_theme_rtl@4x

@brampitoyo brampitoyo removed the needs:UX-feedback Needs UX Feedback label Mar 16, 2020
@Mugurell Mugurell self-assigned this Mar 16, 2020
@Mugurell Mugurell removed the needs:triage Issue needs triage label Mar 16, 2020
@Mugurell Mugurell added this to doing in 4.2 Mar 19, 2020
@Mugurell Mugurell moved this from doing to ready for review in 4.2 Mar 19, 2020
@Mugurell Mugurell moved this from ready for review to doing in 4.2 Mar 19, 2020
@Mugurell
Copy link
Contributor Author

@apbitner Although this ticket initially only referenced the theme picker images
in review it was seen,
based on https://drive.google.com/file/d/11-3sSjg9PvJAjTbRJ_UMC1gghWnPelVS
that we'd also need similar rtl resources for the toolbar position picker images.

Can you help with these here so this ticket will land the resources for both pickers at the same time for a cohesive onboarding UX?

@Mugurell
Copy link
Contributor Author

We also need to keep in mind the in-flight #7606 which comes to modify the same imagery.

@apbitner
Copy link

apbitner commented Mar 19, 2020

Gray border assets have also been added to #7606 for both the Theme and Toolbar cards

@Mugurell Mugurell changed the title Support RTL for theme picker images in Onboarding Support RTL for theme / toolbar position picker images in Onboarding Mar 20, 2020
@Mugurell
Copy link
Contributor Author

Thank you @apbitner for the images!

This patch will add just

  • the purple bordered rtl theme picker images and
  • the gray bordered rtl toolbar position picker images

since the ltr versions of these images only had this purple / gray border and not both.
Will leave it for #7606 to add the rest of the imagery and properly handle switching between them.

@sv-sdeiac
Copy link

Hi, I can confirm that the radio button for the "Take a position" card on RTL language is displayed correctly but with the actual image, the radion button hovers the content from the displayed image.

Devices:

  • Samsung Galaxy Tab S6 (Android 9);
  • Google Pixel 3 (Android 10).

Build:

  • Firefox Preview Nightly 3/23 #20830607.

Notes:

Screenshot_10

  • An additional note is that the images from the "Take a position" card don't display correctly the app experience.
  • I think that till the images will be updated to a faithful experience with the app, the actual images need to be mirrored since the content from them are not in the same place as the position in the app. I filled the ticket [Bug]The images for the "Take a position" card are not correctly mirrored on RTL #9316 for tracking this issue.
  • Also, I want to specify that the "Choose your theme" card icons are mirrored correctly.

@sv-sdeiac sv-sdeiac added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 23, 2020
@liuche liuche mentioned this issue Mar 24, 2020
32 tasks
@liuche liuche moved this from doing to done in 4.2 Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR
Projects
No open projects
4.2
done
Development

No branches or pull requests

5 participants