Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Support of 3rd party password manager #87

Closed
bbinto opened this issue Dec 3, 2018 · 56 comments
Closed

Support of 3rd party password manager #87

bbinto opened this issue Dec 3, 2018 · 56 comments
Labels
feature request 🌟 New functionality and improvements 🙅 waiting Issues that are blocked or has dependencies that are not ready

Comments

@bbinto
Copy link
Contributor

bbinto commented Dec 3, 2018

Why/User Benefit/User Problem

Allow users to fill in their logins from their preferred password manager, e.g. LastPass

What / Requirements

Show dialog/prompt to use 3rd party app to fill in login information

Acceptance Criteria (how do I know when I’m done?)

  • Password manager app can access Fenix
  • Fenix offers dialog to select preferred pwd manager
  • Fenix fills out logins automatically
  • Focus app parity

┆Issue is synchronized with this Jira Task

@bbinto bbinto added this to the Fenix 1.0 milestone Dec 3, 2018
@bbinto bbinto added the feature request 🌟 New functionality and improvements label Dec 3, 2018
@bbinto bbinto changed the title Support of 3rd party password manager [Meta] Support of 3rd party password manager Jan 21, 2019
@bbinto bbinto modified the milestones: Fenix V1.0, MVP Metas Jan 21, 2019
@bbinto bbinto removed feature request 🌟 New functionality and improvements labels Jan 25, 2019
@bbinto bbinto added this to Unassigned in Fenix MVP Jan 25, 2019
@bbinto bbinto added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jan 25, 2019
@bbinto
Copy link
Contributor Author

bbinto commented Jan 29, 2019

The idea is to use 3rd party password managers to let users fill in their saved logins, it's not via FX sync, but rather via other apps, ideally via Lockbox.

We should talk to UX (@brampitoyo and @lime124 ) how we can make sure to surface the option for users to use Lockbox as a password manager (should be some UI provided inside Fenix to advertise for this).

@bbinto bbinto added the must label Jan 30, 2019
@lime124
Copy link
Collaborator

lime124 commented Feb 1, 2019

@bbinto as far as I can tell, all the UI is going to be either via the 3rd party apps or something provided by the OS. It doesn't seem like there's anything for UX to provide to simply access their passwords in the app of their choice. @colintheshots am I missing something?

@bbinto If you are you wanting some sort of specific Fenix UI that is getting new users to go and download Lockbox, I think that should be a separate GitHub issue from this one which is just letting people get access to whatever they are already using.

Am I misunderstanding something?

@brampitoyo
Copy link

@bbinto I’m confirming @lime124 that Lockbox integration will mostly rely on the Lockbox.app to implement an accessibility service that users will need to turn on inside Android Settings.

Something that looks like this:

lockbox-accessibility

After this feature has been toggled on, the user will get a suggestion UI when visiting any website (using any browser, not just Fenix) that contains username/password fields:

@bbinto bbinto moved this from Unassigned to Milestone 3 (Q1) in Fenix MVP Feb 6, 2019
@bbinto bbinto added meta size S 🙅 waiting Issues that are blocked or has dependencies that are not ready and removed 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Feb 7, 2019
@bbinto
Copy link
Contributor Author

bbinto commented Feb 8, 2019

Next Lockbox update early March

@bbinto
Copy link
Contributor Author

bbinto commented Feb 8, 2019

Idea re: flow

  • Keep password in library, detect if Lockbox is installed, if not, promote, otherwise open Lockbox directly

GV has implemented Autofill API

@bbinto
Copy link
Contributor Author

bbinto commented Feb 8, 2019

@linuxwolf to confirm if his test was done on Focus GV, and post results here.

@linuxwolf
Copy link

Original tests may not been using the GeckoView engine in Firefox.

However, after verifying "Latest GeckoView" is toggled on, can confirm that Lockbox can fill into a page on Firefox Focus for Android.

@sandysage
Copy link

I think this is also related: mozilla-mobile/reference-browser#574

@sandysage
Copy link

Just to close the loop here, I believe we're planning to use the autofill api as @bbinto mentions above, and not the accessibility route. Further discussion in #550.

@bbinto
Copy link
Contributor Author

bbinto commented Mar 13, 2019

I'd like to suggest that this ticket/meta/epic is about the support of 3rd party passwords in general, i.e Autofill API.

@sandysage your suggestions, covered in #821 and #550 is def. a wonderful "nice to have" but not required for MVP. We'll keep it in the backlog and personally, I think, at a high priority.

@sandysage - I wonder if your engineers could help out with this work instead?

@bbinto
Copy link
Contributor Author

bbinto commented Mar 13, 2019

@pocmo and @st3fan - has the required A/C work been done (support of 3rd party password manager), and if so, has this been loaded into Fenix nightly yet?

@vesta0
Copy link
Collaborator

vesta0 commented Aug 8, 2019

Hi @sv-ohorvath would you please re-test this with 1password, dashlane, and Bitwarden and let us know the most recent status before I reach out to them? Thanks so much!

@andreicristianpetcu
Copy link

@vesta0 I tested with Bitwarden and it filtered the password corredtly based on the site! Nightly build.

@matteocontrini
Copy link

I can confirm that 1Password works as well

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Aug 12, 2019

@vesta0 Cannot search the list of all passwords on 1Pass saved from other apps. Can only see the passwords saved from Fenix. Chrome can search through all the website-related items in the vault.
Dashlane only shows the autofill pop-up for Fenix, there should also be a hovering bubble (the app logo hovering) to search/add new passwords, like on Chrome.
Bitwarden works ok with new/existing passwords.
the device used: Pixel 3 (Android 9)

@vesta0
Copy link
Collaborator

vesta0 commented Aug 12, 2019

Thanks @sv-ohorvath do 1Pass and Dashboard work similarly to Chrome in Fennec?

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Aug 13, 2019

Hey @vesta0, tried to find out why they didn't work the same and it seems it's a time matter, the other saved passwords will appear but they need some time, Chrome and Fennec don't show the others immediately either. So all 3: Dashlane, 1Password, Bitwarden seem to work fine on Fenix Nightly. Should we close this?

*Oops, accidentally closed it anyway :)

Fenix Q3 Feature Backlog automation moved this from Must to Done! Aug 13, 2019
@sv-ohorvath sv-ohorvath reopened this Aug 13, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Aug 13, 2019

Thank you @sv-ohorvath and all of our contributors who helped test this!

@vesta0 vesta0 closed this as completed Aug 13, 2019
@bifleming bifleming removed this from Unnassigned to Release in Fenix: A-S Bugs Aug 13, 2019
@androidacy-user
Copy link

androidacy-user commented Jan 24, 2020

I can confirm this isn't fixed.
Latest LastPass beta isn't showing any AutoFill prompts, and it's been granted accesibility permission.
Tried Preview and Preview Nightly.

Pixel 2 XL, Android 10

@st3fan
Copy link
Contributor

st3fan commented Jan 24, 2020

@vesta0 it may be a good idea to re-test this - i am pretty sure we asked all of the password managers to whitelist all our build flavors but that was a long time ago so maybe it is a good idea to verify again

@3eresa
Copy link

3eresa commented Jan 29, 2020

@st3fan I just tested LastPass stable version 4.11.4.4946 on the latest Play Store Preview Nightly 200128 18:00 and Preview 3.0.2 LastPass will not fill through the autofill api. It does work on Chrome stable and Firefox version 68.4.2 not sure if it is a whitelist issue or what.

Tested on Essential PH-1 Android 10

@jacobhanson1010
Copy link

Having the same issue with nightly and preview using Lastpass. It's the only thing keeping me from using preview!

@sys9kdr
Copy link

sys9kdr commented Feb 20, 2020

I have the same issue with preview nightly and LastPass. LastPass says "LastPass was unable to auto-fill this app".

Firefox Nightly
Version 75.0a1
Build ID 20200218093736

LastPass 4.11.4.4946

Screenshot_20200221_002406_org mozilla fenix nightly

@3eresa
Copy link

3eresa commented Mar 12, 2020

Still unable to use LastPass through the auto fill API on Nightly 200311 18:01 with LastPass version 4.11.7.5061 on Pixel 3 Android 10 build QQ2A.200305.002. Preview version 3.2.1 doesn't work. Stable version 68.6.0 works fine as does latest Chrome. This is the only thing preventing me from adopting the new Firefox.

@leonardehrenfried
Copy link

leonardehrenfried commented Mar 13, 2020

@3eresa: This isn't going to be the answer you are expecting but all my password manager problems went away after I switched from Lastpass to Bitwarden. Therefore I suspect a Lastpass problem, whose quality I perceived to be getting worse and worse, hence me switching.

@3eresa
Copy link

3eresa commented Mar 18, 2020

Still not working with latest LastPass on most recent Nightly 200318 06:01. Yes I understand I could change personal password managers to avoid this issue however my work uses LastPass Enterprise and there is not much I can do about that. There are nearly 17 million LastPass users. This is going to be an issue when this goes from development releases to final if it's not resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request 🌟 New functionality and improvements 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
No open projects
Development

No branches or pull requests