Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Spacing between top sites on homepage is too big #8719

Closed
sv-sdeiac opened this issue Feb 25, 2020 · 1 comment
Closed

[Bug]Spacing between top sites on homepage is too big #8719

sv-sdeiac opened this issue Feb 25, 2020 · 1 comment
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page needs:triage Issue needs triage S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@sv-sdeiac
Copy link

sv-sdeiac commented Feb 25, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Add some new Top Sites to the homescreen page;
  2. Observe the Homescreen Top Sites list.

Expected behavior

There is no visual defect displayed.

Actual behavior

The spacing between the Top Sites options is too large.

Device information

  • Android device: Nexus 9 (Android 7.1.1) - 1536 x 2048 pixels, 4:3 ratio (~281 ppi pixel density);
  • Fenix version: Firefox Preview Nightly 2/25 @20560606.
  • Notes: The issue is displayed in both Landscape/Portrait mode.
    Screenshot_20200225-122058
    Screenshot_20200225-122014

┆Issue is synchronized with this Jira Task
@sv-sdeiac sv-sdeiac added 🐞 bug Crashes, Something isn't working, .. Feature:Shortcuts Top Sites/Topsites on the Firefox home page S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Feb 25, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 25, 2020
@mcarare mcarare added needs:ac Needs Android Component Work and removed needs:ac Needs Android Component Work labels Feb 25, 2020
@mcarare mcarare self-assigned this Feb 25, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 25, 2020
For mozilla-mobile#8719: Keep RecyclerView from stretching to fill up…
98ad214 
… parent width
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 25, 2020
For mozilla-mobile#8719: Keep top site item at mock width size, preve…
2878562 
…nt stretching
boek pushed a commit that referenced this issue Feb 26, 2020
@boek
For #8719: Keep RecyclerView from stretching to fill up parent width
2add077
boek pushed a commit that referenced this issue Feb 26, 2020
@boek
For #8719: Keep top site item at mock width size, prevent stretching
09e0c0b
@mcarare mcarare added the eng:qa:needed QA Needed label Feb 26, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Feb 26, 2020

Hi, verified as fixed on the latest Nightly Build #20570604 from 02/26 using the following devices:
• Google Pixel 3a (Android 9)
• Samsung Galaxy Tab A (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Google Pixel C (Android 8.0.0)
• Samsung Galaxy S7 (Android 7)
• Huawei MediaPad M3 Lite 10 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Screenshot from Samsung Galaxy Tab A
rsz_screenshot_20200226-142940_firefox_nightly

@AndiAJ AndiAJ closed this as completed Feb 26, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Feb 26, 2020
@gabrielluong gabrielluong mentioned this issue Feb 26, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page needs:triage Issue needs triage S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sv-sdeiac @mcarare @AndiAJ