Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Update collection design on home #8764

Closed
topotropic opened this issue Feb 26, 2020 · 2 comments · Fixed by #9129
Closed

Update collection design on home #8764

topotropic opened this issue Feb 26, 2020 · 2 comments · Fixed by #9129
Assignees
@mcarare
Labels
eng:qa:verified QA Verified Feature:Collections feature request 🌟 New functionality and improvements
Projects
4.2

Comments

@topotropic
Copy link

topotropic commented Feb 26, 2020 •
edited by data-sync-user

Why/User Benefit/User Problem

Reduce noise on home and improve how a collection entry is displayed.

What/Requirements

  • update design based on specs (see screenshot)
  • remove icons (share, menu) in collapsed state
  • remove URL preview text in collapsed sate
  • show icons (share, menu) in opened state
  • use list component to show sites that are part of a collection

image

image

┆Issue is synchronized with this Jira Task
@topotropic topotropic added the feature request 🌟 New functionality and improvements label Feb 26, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 26, 2020
@topotropic topotropic changed the title Simplify collapsed collection on home Updated collection design on home Feb 26, 2020
@topotropic topotropic changed the title Updated collection design on home Update collection design on home Mar 5, 2020
@topotropic topotropic mentioned this issue Mar 10, 2020
Closed
@topotropic topotropic mentioned this issue Mar 10, 2020
Closed
@mcarare mcarare self-assigned this Mar 11, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 11, 2020
For mozilla-mobile#8764: Update collection design, including list ele…
7e3dcc6 
…ments
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 11, 2020
For mozilla-mobile#8764: Update collection design, including list ele…
662c3d0 
…ments
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 11, 2020
For mozilla-mobile#8764: Update collection design, including list ele…
60666bb 
…ments
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 12, 2020
For mozilla-mobile#8764: Update collection design, including list ele…
eb768e8 
…ments
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 12, 2020
For mozilla-mobile#8764: Use list component for items in collections
5a2c13f
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 12, 2020
For mozilla-mobile#8764: Update collection design, including list ele…
6281537 
…ments
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 12, 2020
For mozilla-mobile#8764: Update collection design, including list ele…
96c240f 
…ments
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 12, 2020
For mozilla-mobile#8764: Use list component for items in collections
f7e2c3c
@topotropic topotropic mentioned this issue Mar 16, 2020
Closed
@mcarare mcarare added this to ready for review in 4.2 Mar 18, 2020
@mcarare mcarare linked a pull request Mar 18, 2020 that will close this issue
For #8764: Update collection design on home #9129
Merged
4 tasks
mcarare added a commit to mcarare/fenix that referenced this issue Mar 23, 2020
@mcarare
For mozilla-mobile#8764
61c1ca3
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 23, 2020
@mcarare
For mozilla-mobile#8764: Use list component for items in collections
4205587
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 23, 2020
@mcarare
For mozilla-mobile#8764: Update collection design, including list ele…
0711fa0 
…ments
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 23, 2020
@mcarare
For mozilla-mobile#8764: Use list component for items in collections
f881905
ekager pushed a commit that referenced this issue Mar 28, 2020
@ekager
For #8764: Update collection design, including list elements
62bbbd9
ekager pushed a commit that referenced this issue Mar 28, 2020
@ekager
For #8764: Use list component for items in collections
18533d3
@ekager ekager added the eng:qa:needed QA Needed label Mar 28, 2020
@ekager
Copy link
Contributor

ekager commented Mar 28, 2020

opening for verification

@ekager ekager reopened this Mar 28, 2020
@sv-sdeiac
Copy link

sv-sdeiac commented Mar 30, 2020 •
edited

Hello, I can confirm that this issue is fixed using the latest version of Firefox Preview Nightly 3/29 #20891805.

Devices:

  • Google Pixel 3 (Android 10);
  • Samsung Galaxy Tab S6 (Android 9);
  • LG g7 fit (Android 8.1).

Additionally, I want to specify that in the dark theme mode, the icons are weird since they have two rows of outlines(the grey outline with the see-through of the theme color and the favicon outline). This issue is displayed also when the page doesn't have a specific icon on Dark/Light mode.

Update:

  • As I speak with @mcarare, he decided to follow-up on this question here.

@sv-sdeiac sv-sdeiac added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 30, 2020
@liuche liuche moved this from ready for review to done in 4.2 Mar 30, 2020
@liuche liuche mentioned this issue Apr 13, 2020
Closed
32 tasks
@ekager ekager removed the needs:triage Issue needs triage label Apr 17, 2020
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
eng:qa:verified QA Verified Feature:Collections feature request 🌟 New functionality and improvements
Projects
No open projects
4.2
done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #8764: Update collection design on home mcarare/fenix
4 participants
@topotropic @ekager @sv-sdeiac @mcarare