Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] The text is overlapping in private mode when allow search suggestion popup is displayed #9550

Closed
ebalazs-sv opened this issue Mar 31, 2020 · 1 comment
Closed

[Bug] The text is overlapping in private mode when allow search suggestion popup is displayed #9550

ebalazs-sv opened this issue Mar 31, 2020 · 1 comment
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@ebalazs-sv
Copy link

ebalazs-sv commented Mar 31, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Launch Fenix and go to private mode;
  2. Go to a page, www.twitter.com;
  3. Tap on the URL bar;
  4. Observe the behavior;

Expected behavior

All the page elements are visible.

Actual behavior

The text "This time search with:" is overlapping the Allow search suggestions popup.

Notes

Screenshot

Device information

  • Android device: Google Pixel 3 XL (Android 9), Samsung Galaxy S9 (Android 8), Sony Xperia Z5 (Android 7), Nexus 5 (Android 6.0.1).
  • Fenix version: Nightly 200331, GV 76, 3/31 (Build #20910606).

As Diana mentioned in #7059 (comment) this is a regression.

┆Issue is synchronized with this Jira Task
@ebalazs-sv ebalazs-sv added the 🐞 bug Crashes, Something isn't working, .. label Mar 31, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 31, 2020
@ebalazs-sv ebalazs-sv added S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist Feature:Search labels Mar 31, 2020
@sflorean sflorean mentioned this issue Apr 8, 2020
Closed
@ekager ekager mentioned this issue Apr 18, 2020
Closed
ekager pushed a commit to ekager/fenix that referenced this issue Apr 18, 2020
@jl-roberts @ekager
For mozilla-mobile#9550 - Don't overlap search with shortcuts text
8ee0725 
Private mode search with suggestion onboarding was overlapping "This time, search with: " text. Adjust constraints to allow it to show under onboarding when present.
mcarare pushed a commit that referenced this issue Apr 23, 2020
@jl-roberts @mcarare
For #9550 - Don't overlap search with shortcuts text
26e8d9b 
Private mode search with suggestion onboarding was overlapping "This time, search with: " text. Adjust constraints to allow it to show under onboarding when present.
@mcarare mcarare added the eng:qa:needed QA Needed label Apr 23, 2020
Amejia481 pushed a commit to Amejia481/fenix that referenced this issue Apr 23, 2020
@jl-roberts @Amejia481
For mozilla-mobile#9550 - Don't overlap search with shortcuts text
d500430 
Private mode search with suggestion onboarding was overlapping "This time, search with: " text. Adjust constraints to allow it to show under onboarding when present.
@sv-sdeiac
Copy link

sv-sdeiac commented Apr 24, 2020 •
edited
Loading

Hi, I can confirm that this issue is not reproducible using the latest version of Firefox Preview Nightly 4/24 #21150607.

Devices:

  • LG g7 fit (Android 8.1);
  • Samsung Galaxy Note 8 (Android 9);
  • Google Pixel 3(Android 10).

@sv-sdeiac sv-sdeiac added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 24, 2020
@abodea abodea removed the needs:triage Issue needs triage label Apr 24, 2020
@mcarare mcarare mentioned this issue Apr 27, 2020
Closed
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sv-sdeiac @abodea @ebalazs-sv @mcarare